[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#695130: First commits in git repository on Alioth [ Was: Re: openmotif is now LGPL, retirement of lesstif in jessie?]



Hi Graham and Joël,

[ Graham, should I drop direct e-mail to you, i.e. do you receive the
mail via the PTS anyway? ]

As you might have seen, I set up a git repository on Alioth [1], with a
link to it from the PTS [2]. I used "git import-dscs" to get a proper
history of (open)motif, at least as far as available from snapshot.d.o.
Future tar balls should be imported by using "git import-orig"

> Paul: I saw your mail regarding my request to join collab-maint, thanks.

It seems you don't have access yet, I fear, see below.

> Besides my packaging of motif 2.3.4 I made available here:
> https://launchpad.net/~ginggs/+archive/ppa/

I looked at your work, and it looks good. I have several minor
questions/remarks.
- Did you make any changes to be able to upgrade the standard version
  (I always note the changes in the changelog, even if there are none)
- Do I understand correctly that you replaced autotools by a dependency
  on dh_autoconf? (Please note these things in the changelog).
- Could we propose a configuration flag for the demo stuff, so that
  upstream can keep track of the demo programs and we don't have to
  patch the source?
- My fix [3] for "format not a string literal and no format arguments"
  is slightly different for sprintf cases. Shouldn't it be better to
  replace the sprintf by a simple strcpy?
- d/motif-client.links is not useful now, I suggest you remove it.
- I like to reduce the amount of lintian warnings as well. I will
  propose some fixes later.
- I was thinking that it might be a good idea to ship the three
  libraries in separate packages, so that we fulfill policy 8.1 and get
  lintian happy on that point.

I would like you to do the git push of the 2.3.4 stuff. Do you want to
wait until you have access to collab-maint, or do you want me to commit
your changes, and contribute my changes as well?

Paul

[1] http://anonscm.debian.org/gitweb/?p=collab-maint/motif.git
[2] http://packages.qa.debian.org/o/openmotif.html
[3]
http://anonscm.debian.org/gitweb/?p=collab-maint/motif.git;a=blob;f=debian/patches/0005-sprintf-error-message-hardening-format-security.patch;h=ccd948b732ac1d712fff94b98c1dea031e2d8401;hb=ebb1dcb10b5cf9192886b5c27f5d89706b7a4606

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: