Bug#64914: none

[Julian Gilbey <J.D.Gilbey@qmul.ac.uk>]

On Sat, Mar 30, 2002 at 04:17:01PM -0500, Adam Di Carlo wrote:
> It's untested, but I'm about to test it and play around with it,
> should be uploaded shortly.

Well done!

Some small comments follow....

> +    if [ -f ${FMTDIR}/40jadetex.cnf ] || 
> +       ls ${FMTDIR}/*jadetex.cnf 2>/dev/null; then
> +        :
> +    elif [ -f ${FMTDIR}/40jadetex.cnf.disable ]; then
> +        mv ${FMTDIR}/40jadetex.cnf.disable ${FMTDIR}/40jadetex.cnf
> +    else
> +        OLD=`ls -1 ${FMTDIR}/*jadetex.cnf* | tail -1`

How do you know this will output anything?  Better would be:
    OLD="`ls -1 ${FMTDIR}/*jadetex.cnf.* 2>/dev/null | tail -1`"

Note three changes: cnf* -> cnf.* (as this is what you test for
later), double quotes (in case it's empty), and the 2>/dev/null.

> +        if [ -f ${OLD} ]; then

You would probably be better to test:
    if [ -n "${OLD}" ] && [ -f "${OLD}" ]; then

> +            NEW=`echo $OLD | sed -e 's/.cnf.*/.cnf/'`
> +            mv ${OLD} ${NEW}
> +        else
> +            cp ${TEMPLDIR}/fmtutil.cnf ${FMTDIR}/40jadetex.cnf
> +        fi
>      fi

Only other comment is that using mktexlsr would be better than texhash
in the postinst and prerm, being the new name for the old script.

   Julian

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

     Julian Gilbey, Dept of Maths,             Debian GNU/Linux Developer
      Queen Mary, Univ. of London         see http://people.debian.org/~jdg/
   http://www.maths.qmul.ac.uk/~jdg/           or http://www.debian.org/
        Visit http://www.thehungersite.com/ to help feed the hungry


-- 
To UNSUBSCRIBE, email to debian-tetex-maint-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org