[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Should any of the glibc-pre2.1 sparc patches be sent upstream?



On Fri, Dec 18, 1998 at 04:44:49AM -0800, Joel Klecker wrote:
> >sparc-broken-bash
> >Work around the broken bash and signal handling on sparc.
> 
> Can you explain how this patch fixes what it apparently fixes? I 
> don't understand how patching a timezone file accomplishes that.

It's not really obvious ;-)
With our slightly broken signal setup with everything before
glibc2.0.95-3 you got 'Wild result: -1' errors because of the offending
lines. It was just a convenience patch for our slightly broken
environment ;-)

> 
> >sparc-chown             Sparc needs chown handling like i386.
> 
> This one will not be submitted because the i386 chown kluge is 
> universally hated by the glibc developers. I did send one based on 
> the powerpc chown solution used in glibc 2.1. I have yet to receive 
> any response to it.

Fine with me.

> 
> >sparc-sigstack
> >We _really_ don't want to see functions which rely on sigaltstack.
> 
> Hmm... not this one.

Unfortunately sigstack and sigaltstack aren't wrapped around. If you
compile programs which use sigstack on a 2.0.x kernel with a glibc
without this patch and the next one you'll produce broken binaries.
 
> 
> >sparc-syscalls
> >Fix to `getdomainname' and other syscalls in Sparc, and remove syscalls which
> >are only present in SunOS or Sparc/Linux 2.1.
> 
> Should the SunOS part of this be sent upstream? The 2.1-specific 
> stuff is supposed to be wrapped around, and really shouldn't need to 
> be hidden.

Ask davem what to do about the SunOS stuff. As we'll get a Sparc slink
release I wanted to be _sure_ that we won't use any 2.1 features.

> 
> >sparc-ldso
> >Fail safe on broken getcwd in 2.0.35 kernels for now.
> 
> OK, that's not going in.
> 
> >sparc-sigaction
> >Correct return value when no oact is given to sigaction.
> 
> This one?

This one is really important and should go upstream. Without this
patch you get weird sigaction behaviour. Otherwise if you reinstall a signal
handler you get 
Error: Success 
messages. The routine returns -1 although there was no error.

Greetings,



				Christian 
   
-- 
Christian Meder, email: meder@isr.uni-stuttgart.de

What's the railroad to me ?
I never go to see
Where it ends.
It fills a few hollows,
And makes banks for the swallows, 
It sets the sand a-blowing,
And the blackberries a-growing.
                      (Henry David Thoreau)


Reply to: