Dear Samuel, On 05.06.21 13:00, Samuel Henrique wrote:
thank you for the positive feedback, your review and yours proposals for improving my tests concerning `rsakeyfind`.This is a really nice contribution!
To omit the storage of binary blobs, I changed the test cases, as requested, so that the dump files will be created during the tests' runtime using the helper scripts mentioned in my previous message.I left a comment there related to this, I believe you will have to automate the generation of those dmp files because otherwise we have issues due to missing their source code.
Within each testcase certain key material is specified [1], which will be used for the deterministic generation of the RSA key by feeding the key material to a helper script [2], where the elements (d, p, q and e) are parsed and then used for constructing a keypair with the help of `python3-pycryptodome`. The process memory of this process is dumped afterwards [3] and used as an input for `rsakeyfind`, whose result is check against the seeded key material. Please note, that this procedure requires the availability of the packages `gdb`, `procps` and `python3-cryptodome` in the test environment [4].
For the actual implementation, please refer to my updated merge request at [5]. I hope this solution fulfills your requirements.
Thanks already in advance for a new review of these changes. Best regards, Jan ---[1] E.g. https://salsa.debian.org/jgru/rsakeyfind/-/commit/68ab6ee99d6185604686af366b42b1b93680fe53#d557498850fdf135fbf9ac75090555e7e44a6de2_0_9 [2] https://salsa.debian.org/jgru/rsakeyfind/-/commit/68ab6ee99d6185604686af366b42b1b93680fe53#b19d0f8fed570abef1d8d978efc03d3f4acae031 [3] https://salsa.debian.org/jgru/rsakeyfind/-/commit/68ab6ee99d6185604686af366b42b1b93680fe53#2db197d229ba2045d734add362dad0fec00f6734 [4] https://salsa.debian.org/jgru/rsakeyfind/-/commit/68ab6ee99d6185604686af366b42b1b93680fe53#83223a554d33ba7e1888274ff8ac43adb8147ba0_0_2 [5] https://salsa.debian.org/pkg-security-team/rsakeyfind/-/merge_requests/2/pipelines, it builds flawlessly now