[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-sawyer ruby-octokit



Hey,

On 22/09/19 6:21 pm, Samyak Jain wrote:
>
>     >>> https://salsa.debian.org/ruby-team/ruby-octokit
>     >> I can't parse the need for uploading ruby-octokit.
>     >> Not uploading at the moment. I might be missing something, so
>     waiting
>     >> for the clarification.
>     > If some one already has ruby-sawyer 0.8.1 installed, updating
>     ruby-sawyer in the archive alone will not pull the updated
>     version. So we need to bump minimum version of ruby-sawyer in
>     ruby-octokit and minimum version of ruby-octokit in gitlab.
>
>     Samyak,
>     While trying to achieve this, the changes made by you on the salsa
>     repository is not needed. Instead, a small change in the d/control is
>     enough.
>     This commit[1] is totally not needed here. And the commit for
>     "relaxing"
>     dependency[2] is incorrect.
>     What you did (removing the backporting symbol) doesn't solve the
>     problem
>     here, but raises another.
>     The ideal way of going about this IMHO is to just bump the version in
>     d/control. Patch attached.
>
>     Also, you'll need to "git revert" these commits and make changes
>     to d/ch
>     appropriately.
>
>
> Thanks for pointing on the mistake, I have reverted the unwanted
> patch, and have made necessary amendments.

While you bumped the version in "Build-Depends", you forgot to check the
"Depends".
Nevermind, fixed for now.
Also,
- Imported tests. They're running now \o/
- Fixed other things. Check the commits.

Thanks for the work. Uploaded!


Best,
Utkarsh


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: