[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ruby_parser test case failure with 1.9.1 and plans for 1.9.2



Praveen A escreveu isso aí:
> 2011/9/6 Antonio Terceiro <terceiro@debian.org>:
> > Usually we also want to remove insane manipulations of the $LOAD_PATH,
> > such as:
> >
> >  $:.unshift "../../ruby_parser/dev/lib"
> >  $:.unshift "../../ruby2ruby/dev/lib"
> >
> > ($: == $LOAD_PATH)
> >
> > I updated your patch, check 1db9635. Please ping me again when
> > ruby-sexp-processor hits the archive. It was already accepted, so this should
> > be really soon now.
> 
> It is in the archive now, I updated the patch for dep3.

uploaded, thanks

> > --------------------------------------------------------------------
> >
> > re ruby-cutest:
[...]
> > debian/ruby-tests.rb is all commented out, but there are tests in the
> > package to be run during the build.
> 
> I updated it, but I think I will need help with this. It is using its
> own syntax (cutest syntax) and I followed its README. But one test is
> failing. But it doesn't appear as failure to our test_runner.
> 
> error output is
> 
> /usr/bin/ruby1.8 -I/usr/lib/ruby/vendor_ruby
> /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb
> ..................
> 
> Cutest::AssertionFailed: "\n" != ".\n"
> 
> - assert_equal(stdout, expected) ./test/run.rb +20
> 
> /usr/bin/ruby1.9.1 -I/usr/lib/ruby/vendor_ruby
> /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb
> ..................
> 
> Cutest::AssertionFailed: "\n" != ".\n"
> 
> - assert_equal(stdout, expected) ./test/run.rb +20
> 
> Any ideas?

the failing test says

  Cutest.run(Dir["test/fixtures/success.rb"])

but test/fixtures/success.rb does not exist. You should probably send a patch
to upstream adding test/fixtures to the distributed gem.

Another thing: I could only make these tests run by adding the following to the
top of debian/ruby-tests.rb:

  ENV['PATH'] = 'debian/ruby-cutest/usr/bin:' + ENV['PATH']

That's because I do not have cutest installed via rubygems or in any other way.
You could catch this building in a clean chroot.

Also, gem2deb is running the tests before updating the shebangs in the
installed programs: these tests will not like this. I will upload a new gem2deb
release today, please change the build-depends to `gem2deb (>= 0.2.8~)` for
this package.

-- 
Antonio Terceiro <terceiro@debian.org>

Attachment: signature.asc
Description: Digital signature


Reply to: