[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Unblock request for dovecot



On Mon, Nov 19, 2012 at 22:32:15 -0500, Jaldhar H. Vyas wrote:

> [CCs requested as I am not subscribed to the list.]
> 
> Dear RMs, I know the time is late and this is a long shot but I am
> requesting that the current version of dovecot 1:2.1.7-5 be
> unblocked for
> testing because:
> 
+      echo "You already have ssl certs for dovecot."
+      echo "However you should move them out of /etc/ssl"
+      echo "and into /etc/dovecot and update the configuration"
+      echo "in /etc/dovecot/conf.d/10-ssl.conf accordingly."
+      echo "See /usr/share/dovecot-core/NEWS.Debian for details."

1) people are not going to see this, in the middle of dist-upgrading a
thousand packages
2) the path to NEWS.Debian is wrong

+if [ "$1" = "triggered" ]; then
+    if [ -x "/etc/init.d/dovecot" ]; then
+        if [ -x /usr/sbin/invoke-rc.d ]; then
+            invoke-rc.d dovecot start
+        else
+            /etc/init.d/dovecot start
+        fi
+    fi
+fi

How can this ever work in postrm?  (as far as I know only postinst can
be called this way, and anyway starting a daemon in postrm doesn't seem
to make much sense)
The switch to triggers is not appropriate at this stage IMO anyway, and
should be deferred to the next release.

--- dovecot-2.1.7/debian/dovecot-managesieved.README.Debian
1970-01-01 00:00:00.000000000 +0000
+++ dovecot-2.1.7/debian/dovecot-managesieved.README.Debian
2012-11-14 20:10:38.000000000 +0000
@@ -0,0 +1,17 @@
+Removing dovecot-managesieved
+-----------------------------
+
+If you remove (i.e. with dpkg -r or aptitude remove) this package you will
+get an error something like this:
+
+doveconf: Fatal: Error in configuration file /etc/dovecot/dovecot.conf: 
+service(managesieve-login): executable is empty
+
+To avoid it, make sure 
+/etc/dovecot/conf.d/etc/dovecot/conf.d/20-managesieve.conf has been deleted, 
+moved or completely commented out first.  Alternatively, purge the package 
+instead of removing it.
+
+If you do not do this, dovecot-core will be left in an unconfigured state 
+because the error will cause a trigger to fail.  To fix this simply reinstall 
+dovecot-core.

This seems rather broken, why can't it be fixed properly instead?

The hurd fix is probably not something for right now either.

The tcp wrappers change doesn't seem appropriate either.

Not sure I'm happy about adding hardening this late.

+       chmod 0700 debian/dovecot-core/etc/dovecot/private

You seem to run dh_fixperms afterwards, because as far as I can tell the
deb has

drwxr-xr-x root/root         0 2012-11-14 23:09 ./etc/dovecot/private/

No comment on the pigeonhole thing.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: