Re: Unblock request for dovecot
On Mon, 26 Nov 2012, Julien Cristau wrote:
+ echo "You already have ssl certs for dovecot."
+ echo "However you should move them out of /etc/ssl"
+ echo "and into /etc/dovecot and update the configuration"
+ echo "in /etc/dovecot/conf.d/10-ssl.conf accordingly."
+ echo "See /usr/share/dovecot-core/NEWS.Debian for details."
1) people are not going to see this, in the middle of dist-upgrading a
thousand packages
It should really use debconf but I thought it would be considered too much
of a change.
2) the path to NEWS.Debian is wrong
Yes this was reported as #693621, unfortunately after I had already made
this upload.
+if [ "$1" = "triggered" ]; then
+ if [ -x "/etc/init.d/dovecot" ]; then
+ if [ -x /usr/sbin/invoke-rc.d ]; then
+ invoke-rc.d dovecot start
+ else
+ /etc/init.d/dovecot start
+ fi
+ fi
+fi
How can this ever work in postrm? (as far as I know only postinst can
be called this way, and anyway starting a daemon in postrm doesn't seem
to make much sense)
Dovecot starts a number of daemon processes. If e.g. you removed imapd,
you might still keep the pop3d, managesieved and so on.
The switch to triggers is not appropriate at this stage IMO anyway, and
should be deferred to the next release.
I can take it out.
--- dovecot-2.1.7/debian/dovecot-managesieved.README.Debian
1970-01-01 00:00:00.000000000 +0000
+++ dovecot-2.1.7/debian/dovecot-managesieved.README.Debian
2012-11-14 20:10:38.000000000 +0000
@@ -0,0 +1,17 @@
+Removing dovecot-managesieved
+-----------------------------
+
+If you remove (i.e. with dpkg -r or aptitude remove) this package you will
+get an error something like this:
+
+doveconf: Fatal: Error in configuration file /etc/dovecot/dovecot.conf:
+service(managesieve-login): executable is empty
+
+To avoid it, make sure
+/etc/dovecot/conf.d/etc/dovecot/conf.d/20-managesieve.conf has been deleted,
+moved or completely commented out first. Alternatively, purge the package
+instead of removing it.
+
+If you do not do this, dovecot-core will be left in an unconfigured state
+because the error will cause a trigger to fail. To fix this simply reinstall
+dovecot-core.
This seems rather broken, why can't it be fixed properly instead?
That's the way dovecot works and believe me Marco and I spent a lot of
time trying to figure out a better solution. Possibly dovecot 2.2.x is
better but that's obviously out of the question right?
The hurd fix is probably not something for right now either.
Fixing FTBS on hurd was a release goal no? IIRC the bug was high severity
but if it is not considered important I can take this out.
The tcp wrappers change doesn't seem appropriate either.
It's only an extra cflag really but I can take it out if necessary.
Not sure I'm happy about adding hardening this late.
This was also a release goal wasn't it?
+ chmod 0700 debian/dovecot-core/etc/dovecot/private
You seem to run dh_fixperms afterwards, because as far as I can tell the
deb has
drwxr-xr-x root/root 0 2012-11-14 23:09 ./etc/dovecot/private/
Hmm I thought it was doing the right thing but I can change it if
necessary.
If I make these changes as -6, will the RMs allow it for wheezy?
--
Jaldhar H. Vyas <jaldhar@debian.org>
Reply to: