[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Pre-approval request for t-p-u upload of irqbalance/1.0.3-4



On 08.11.2012 04:24, Aníbal Monsalve Salazar wrote:
> @@ -69,8 +68,7 @@
>          start-stop-daemon --stop --retry 5 --quiet --oknodo --exec $DAEMON
>          rm -f $PIDFILE
>  
> -        start-stop-daemon --start --quiet --oknodo --exec $DAEMON -- $OPTIONS $DOPTIONS
> -        pidofproc $PNAME > $PIDFILE
> +        start-stop-daemon --start --quiet --oknodo --exec $DAEMON -- --pid=$PIDFILE $OPTIONS $DOPTIONS

I would recommend using start-stop-daemons --pidfile option (in addition
to --exec) everywhere. Otherwise it will behave like killall.

The explicit removal of the pidfile in the init script doesn't look like
it's necessary fwiw, as the source code already does an unlink of the
pidfile. So you might consider removing the "rm" calls.
I haven't tested this though, so please test/check this carefully.

Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: