On Thu, Nov 08, 2012 at 01:26:20PM +1100, Aníbal Monsalve Salazar wrote:
>On Thu, Nov 08, 2012 at 12:45:38AM +0100, Michael Biebl wrote:
>>Looking through the irqbalance.c sources, the daemon already writes a
>>pidfile via the -pid command line option. Why do you even need to mess
>>around with the pid file in such a horrible way?
>
>It seems an old bug was fixed by upstream. I'll test -pid soon.
New debdiff below.
diff -Nru irqbalance-1.0.3/debian/changelog irqbalance-1.0.3/debian/changelog
--- irqbalance-1.0.3/debian/changelog 2012-10-23 12:57:07.000000000 +1100
+++ irqbalance-1.0.3/debian/changelog 2012-11-08 14:15:12.000000000 +1100
@@ -1,3 +1,14 @@
+irqbalance (1.0.3-4) testing-proposed-updates; urgency=low
+
+ * Build-dep on libglib2.0-dev (>= 2.28)
+ The g_list functions are only available in glib version 2.28 and higher
+ Closes: #691999
+ * Pass --pid=$PIDFILE to $DAEMON in init script
+ * Don't fail to restart
+ Closes: #692427
+
+ -- Anibal Monsalve Salazar <anibal@debian.org> Tue, 06 Nov 2012 09:09:16 +1100
+
irqbalance (1.0.3-3) unstable; urgency=low
* Fix dependency libnuma-dev [i386 amd64 ia64 mips mipsel powerpc]
diff -Nru irqbalance-1.0.3/debian/control irqbalance-1.0.3/debian/control
--- irqbalance-1.0.3/debian/control 2012-10-23 12:51:06.000000000 +1100
+++ irqbalance-1.0.3/debian/control 2012-11-06 09:13:49.000000000 +1100
@@ -2,7 +2,7 @@
Section: utils
Priority: extra
Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
-Build-Depends: dpkg-dev (>= 1.16.1~), debhelper (>= 9), pkg-config, libglib2.0-dev, xutils-dev, hardening-wrapper, libcap-ng-dev, libnuma-dev [i386 amd64 ia64 mips mipsel powerpc]
+Build-Depends: dpkg-dev (>= 1.16.1~), debhelper (>= 9), pkg-config, libglib2.0-dev (>= 2.28), xutils-dev, hardening-wrapper, libcap-ng-dev, libnuma-dev [i386 amd64 ia64 mips mipsel powerpc]
Standards-Version: 3.9.3
Homepage: http://code.google.com/p/irqbalance/
#Vcs-Svn: svn://irqbalance.googlecode.com/svn/trunk
diff -Nru irqbalance-1.0.3/debian/irqbalance.init irqbalance-1.0.3/debian/irqbalance.init
--- irqbalance-1.0.3/debian/irqbalance.init 2012-06-16 13:02:33.000000000 +1000
+++ irqbalance-1.0.3/debian/irqbalance.init 2012-11-08 13:56:48.000000000 +1100
@@ -50,8 +50,7 @@
exit 0
fi
- start-stop-daemon --start --quiet --oknodo --exec $DAEMON -- $OPTIONS $DOPTIONS
- pidofproc $PNAME > $PIDFILE || ps aux | grep $PNAME$ | sed "s/^root *//;s/ .*//" > $PIDFILE
+ start-stop-daemon --start --quiet --oknodo --exec $DAEMON -- --pid=$PIDFILE $OPTIONS $DOPTIONS
log_end_msg $?
;;
@@ -69,8 +68,7 @@
start-stop-daemon --stop --retry 5 --quiet --oknodo --exec $DAEMON
rm -f $PIDFILE
- start-stop-daemon --start --quiet --oknodo --exec $DAEMON -- $OPTIONS $DOPTIONS
- pidofproc $PNAME > $PIDFILE
+ start-stop-daemon --start --quiet --oknodo --exec $DAEMON -- --pid=$PIDFILE $OPTIONS $DOPTIONS
log_end_msg $?
;;
Attachment:
signature.asc
Description: Digital signature