В Wed, 7 Nov 2012 18:35:44 +0100 Moritz Muehlenhoff <jmm@inutil.org> пишет: > On Wed, Oct 24, 2012 at 06:28:47PM +0200, Moritz Muehlenhoff wrote: > > [..] > > Alexander, what's the status? I am sorry for delay! Most of changes prepared with clean commits, but i still need reply to question about systemd changes: > > > > 3. fix daemons user/group on systems with systemd (Closes: > > > > #679958). delegate daemons uid/gid changing to > > > > start-stop-daemon or systemd, thanks to Matija Nalis (Closes: > > > > #556207). > > > > > > > > This changes are related and intersected. First commit reverted > > > > by last. > > > > > > > > http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d077cd3c71734828b635f8605c8411f6cd86b6f6 > > > > http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=cf9eb640182f4adfd83d05954dc35a20b60170c1 > > > > http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=694b788e0f82a734ca98bb0930a97432240c7fe8 > > > > > > > > Upstream already much time (at least since 2010, Oct) use > > > > start-stop-daemon for change daemons uid/gid in their variant of > > > > init scripts. Our patch for uid/gid changing by systemd was > > > > already accepted into upstream. > > > > > > > > The big problem, that without this change user can't simply get > > > > backtraces on daemons crashes. This backtraces required for some > > > > bugreport to upstream. > > > > > > > Meh. Can't the systemd files be simply removed? If this doesn't > > > affect sysvinit systems I would prefer not to bother. > > > > Hmm. But systemd service files was added to package in 5.2.6+dfsg-1 > > via bug #624532. And patch for fix them is trivial. > > > Apparently not so trivial, since it needs a fixup now. I would rather > not see a change that affects all paths to fix something for the .1% > of users that run systemd. ohh. i think, that will be better to split explanation of this change into two parts. First - changes in sysvinit scripts. Instead of run daemons as root and pass options for chuid we allow start-stop-daemon to run it as non-root. This is what do upstream and without this fix we have a problems with getting backtraces on daemons crashes. Second - changes in systemd service files. In 5.2.6+dfsg-1 our team add this files into packages, but unfortunely, they was shipped with incorrect (empty) uid/gid in them. So, for systemd service files was fixed two problems: a) Change daemons uid/gid by systemd, as do sysvinit scripts. This is separate patch [1] for simplicity sending it to upstream (already accepted by upstream) b) Fixing incorrect uid/gid. Due to limitation of upstream build system we can't use build options and hardcore uid/gid by patch [2] [1] http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/delegate-chuid-to-systemd.patch [2] http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/fix-systemd-daemon-user-group.patch As i understand, your opinion is that will be better do not ship systemd service files at all, but include changes in sysvinit scripts? -- with best regards, Alexander Golovko email: alexandro@ankalagon.ru xmpp: alexandro@ankalagon.ru
Attachment:
signature.asc
Description: PGP signature