On Thu, Nov 08, 2012 at 10:43:57AM +0100, Michael Biebl wrote: >On 08.11.2012 04:24, Aníbal Monsalve Salazar wrote: >>@@ -69,8 +68,7 @@ >> start-stop-daemon --stop --retry 5 --quiet --oknodo --exec $DAEMON >> rm -f $PIDFILE >> >>- start-stop-daemon --start --quiet --oknodo --exec $DAEMON -- $OPTIONS $DOPTIONS >>- pidofproc $PNAME > $PIDFILE >>+ start-stop-daemon --start --quiet --oknodo --exec $DAEMON -- --pid=$PIDFILE $OPTIONS $DOPTIONS > >I would recommend using start-stop-daemons --pidfile option (in addition >to --exec) everywhere. Otherwise it will behave like killall. That's what we want. IMO it doesn't make any sense to have two or more instances of irqbalance running at the same time. >The explicit removal of the pidfile in the init script doesn't look like >it's necessary fwiw, as the source code already does an unlink of the >pidfile. So you might consider removing the "rm" calls. >I haven't tested this though, so please test/check this carefully. When I tested it, irqbalance didn't remove /var/run/irqbalance.pid on stop. If it's already present, irqbalance didn't update it on start.
Attachment:
signature.asc
Description: Digital signature