[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: torcs and torcs-data-*



On Mon, Jul 23, 2012 at 07:59:08PM +0100, Adam D. Barratt wrote:
> On Mon, 2012-07-23 at 12:29 -0500, Rudy Godoy wrote:
> > On Mon, Jul 23, 2012 at 06:18:21AM +0100, Adam D. Barratt wrote:
> > > On Sun, 2012-07-22 at 23:58 -0500, Rudy Godoy wrote:
> > > > So, I ask for allowing torcs-data, torcs-data-tracks and
> > > > torcs-data-cars to enter testing, thus being part of 
> > > > wheezy.
> > > > 
> > > > Changes from 1.3.1 to 1.3.3 include few build bugs and
> > > > upstream including our patches.
> > > 
> > > $ dak ls -s testing torcs-data-{cars,tracks}
> > > torcs-data-cars |    1.3.3-4 |       testing | all
> > > torcs-data-tracks |    1.3.3-4 |       testing | all
> > > 
> > > I'm not sure what you believe needs doing here.
> > > 
> > 
> > That's interesting because PTS and the developer QA page
> > shows differently. Maybe those programs believe the source
> > package is still torcs-data itself.
> 
> No, they show precisely the same - e.g.
> http://packages.qa.debian.org/t/torcs-data.html is the PTS page for the
> "torcs-data" source package, which we've established isn't in testing.
> 
> Both http://packages.qa.debian.org/t/torcs.html and
> http://packages.debian.org/source/sid/torcs show the current status.

I still see a difference here:
http://qa.debian.org/developer.php?login=rudy%40debian.org

and here:
http://packages.qa.debian.org/t/torcs-data.html

The latest one of course is for the source torcs-data package 
which is not available anymore. That's what was confusing.

> 
> > So, in that case I'd like you to let pass rev. 6 (1.3.3-6)
> > packages from sid.
> 
> You're supposed to provide a rationale, not just say "oh, go on,
> please". ;-p
> 
> From a quick look at the diff from the version in testing, lintian fixes
> generally don't qualify for unblocks, nor does a complete rewrite of the
> copyright file in to DEP-5 format.
> 
> I guess one could claim that some of the changes are documentation
> updates, but that's certainly stretching it for the copyright file.
> 

Basically, the DEP-5 involved primarily more detailed licensing terms
for the game's artwork. Which was not included in the past. Few
things remain to clean-up for some data files, I might need to
contact designers/authors for that.

Second, with the new packaging layout I also created an VCs repo
under the pkg-games umbrella, so that we are able to maintain
and support on stable releases.

Finally, nor critical or functional change have been made to the
game. However upstream included few patches in a beta release
that could be useful for this release. It wasn't our case but
Ubuntu's, for some reason. We've already pushed upstream few 
patches in the past. Changes in -6 can be interpreted as polishing
bits for shipping. If those are not elegible let's move and release!

> What's this change about?
> 
> -build-predeb/torcs-data::
> +binary-predeb/torcs-data::
>  # removing empty script until it's ready
>         rm -f debian/torcs-data/usr/share/games/torcs/telemetry/telemetry.sh
> 
> Also, why does debian/rules now contain *two* copies of that removal
> line?
> 

Well, you've already found the answer. 

Thanks again.

-- 
Rudy Godoy
http://stone-head.org


Reply to: