Re: New massxpert source package fixing grave bug

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

On Tue, 2011-02-01 at 19:28 +0100, Filippo Rusconi wrote:
> by this mail I would like to ask the permission to upload to
> testing-proposed-updates a source package that fixes a grave bug that
> occurs on normal operation of the massxpert software.
[...]
> ++    if(m_startIndex < 0)
> ++      m_startIndex = 0; 

This would be fine; uploading as soon as possible would be appreciated
in order to have the best chance of getting the fix in to the release.

I do have a couple of comments, however:

>  patches/debian-changes-2.3.6-1squeeze1 |   41
>  +++++++++++++++++++++++++++++++++

Why is this not an explicit patch, rather than the dpkg "mop-up" auto
patch?

+  * Fix (Closes: #611142)for the crash due to clicking on the left of the
+    first vignette in the sequence editor. This is a bad bug which can be
+    fixed with a single if() statement (C++ language).

imho, the last sentence doesn't belong in a changelog; the fact that the
code is written in C++ is irrelevant to the fix, as is the fact that it
involves adding an if.

Thanks for your work on the package.

Regards,

Adam