[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

New massxpert source package fixing grave bug



[[ CCing Michael Banck, who is kindly helping me with this procedure,
which is new to me ]]


Greetings,

by this mail I would like to ask the permission to upload to
testing-proposed-updates a source package that fixes a grave bug that
occurs on normal operation of the massxpert software.

The affected package in squeeze is version 2.3.6-1. The fixed pacakge
would be version 2.3.6-1squeeze1.

As the upstream of that software package I can tell that the bug is
really grave, as using the software the normal way would inevitably
make it crash.

The fix is only two lines long:

++    if(m_startIndex < 0)
++      m_startIndex = 0; 

The debdiff obtained using:

$ debdiff massxpert_2.3.6-1.dsc massxpert_2.3.6-1squeeze1.dsc  > /tmp/debdiff

is attached to this message.

Further, here the output of the following command:

$ debdiff massxpert_2.3.6-1.dsc massxpert_2.3.6-1squeeze1.dsc|diffstat

 changelog                              |    8 ++++++
 patches/debian-changes-2.3.6-1squeeze1 |   41
 +++++++++++++++++++++++++++++++++
 patches/series                         |    1 
 3 files changed, 50 insertions(+)

I hope you will be able to grant me the authorization to upload the
new version of the package.

Best regards,
                 Filippo

-- 
Filippo Rusconi, PhD - CNRS - public key C78F687C
Author of ``massXpert''     at http://www.massxpert.org
diff -Nru massxpert-2.3.6/debian/changelog massxpert-2.3.6/debian/changelog
--- massxpert-2.3.6/debian/changelog	2010-05-10 20:21:35.000000000 +0200
+++ massxpert-2.3.6/debian/changelog	2011-02-01 19:09:33.000000000 +0100
@@ -1,3 +1,11 @@
+massxpert (2.3.6-1squeeze1) testing-proposed-updates; urgency=low
+
+  * Fix (Closes: #611142)for the crash due to clicking on the left of the
+    first vignette in the sequence editor. This is a bad bug which can be
+    fixed with a single if() statement (C++ language).
+
+ -- Filippo Rusconi <rusconi-debian@laposte.net>  Sun, 30 Jan 2011 20:35:32 +0100
+
 massxpert (2.3.6-1) unstable; urgency=low
 
   * Upstream release:
diff -Nru massxpert-2.3.6/debian/patches/debian-changes-2.3.6-1squeeze1 massxpert-2.3.6/debian/patches/debian-changes-2.3.6-1squeeze1
--- massxpert-2.3.6/debian/patches/debian-changes-2.3.6-1squeeze1	1970-01-01 01:00:00.000000000 +0100
+++ massxpert-2.3.6/debian/patches/debian-changes-2.3.6-1squeeze1	2011-02-01 19:19:56.000000000 +0100
@@ -0,0 +1,41 @@
+Description: Upstream changes introduced in version 2.3.6-1squeeze1
+ This patch has been created by dpkg-source during the package build.
+ Here's the last changelog entry, hopefully it gives details on why
+ those changes were made:
+ .
+ massxpert (2.3.6-1squeeze1) testing-proposed-updates; urgency=low
+ .
+   * Fix (Closes: #611142)for the crash due to clicking on the left of the
+     first vignette in the sequence editor. This is a bad bug which can be
+     fixed with a single if() statement (C++ language).
+ .
+ The person named in the Author field signed this changelog entry.
+Author: Filippo Rusconi <rusconi-debian@laposte.net>
+Bug-Debian: http://bugs.debian.org/611142
+
+---
+The information above should follow the Patch Tagging Guidelines, please
+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
+are templates for supplementary fields that you might want to add:
+
+Origin: <vendor|upstream|other>, <url of original patch>
+Bug: <url in upstream bugtracker>
+Bug-Debian: http://bugs.debian.org/<bugnumber>
+Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
+Forwarded: <no|not-needed|url proving that it has been forwarded>
+Reviewed-By: <name and email of someone who approved the patch>
+Last-Update: <YYYY-MM-DD>
+
+--- massxpert-2.3.6.orig/gui/regionSelection.cpp
++++ massxpert-2.3.6/gui/regionSelection.cpp
+@@ -131,6 +131,10 @@ namespace massXpert
+ // 	      << "m_startIndex:" << m_startIndex
+ // 	      << "m_endIndex:" << m_endIndex;
+     
++    // If m_startIndex is less than 0, then set it to 0.
++    if(m_startIndex < 0)
++      m_startIndex = 0;
++    
+     m_startPoint = mp_view->vignetteLocation(m_startIndex, MXT_NORTH_WEST);
+     m_endPoint = mp_view->vignetteLocation(m_endIndex, MXT_SOUTH_WEST);
+ 
diff -Nru massxpert-2.3.6/debian/patches/series massxpert-2.3.6/debian/patches/series
--- massxpert-2.3.6/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ massxpert-2.3.6/debian/patches/series	2011-02-01 19:19:56.000000000 +0100
@@ -0,0 +1 @@
+debian-changes-2.3.6-1squeeze1

Reply to: