Re: Please unblock php-xml-parser

[Thomas Goirand <zigo@debian.org>]

Hi Mehdi,

Mehdi Dogguy wrote:
> On 09/06/2010 12:04 PM, Thomas Goirand wrote:
>> Hi,
>>
>> My last upload removes the use of a deprecated "return value of new by
>> reference". Please unblock php-xml-parser to have the issue fixed.
>>
> 
> The patch seems ok but:
> 
> 1)  build-stamp: configure-stamp
>         dh_testdir
> +       dpatch apply-all
>         touch build-stamp
>   Why don't using the "patch" target from
> /usr/share/dpatch/dpatch.make?

Sorry, I tried "patch-stamp" instead as I wrongly remembered, it didn't
work, I got pissed, so did like that (too fast, thinking wrongly that it
was acceptable). I'll upload a fix, thanks for your remark.

> 2) +  * Bumps Standard-Version to 3.9.1.
> 
> Not needed.
> 
> 3) +  * Added debian/source/format and debian/README.source
> 
> Not needed.
> 
> Regards,

Other release team members never complained about the above changes, and
I saw people on IRC saying that 2) was fine, and wild-guessed that 3)
was ok.

I'm not saying you are wrong, but rather I'm asking: do you want me to
reverse these changes, and re-upload to SID without them (and the
debian/rules change)?

Thanks for your time are careful reviews,

Thomas