Re: Please unblock php-xml-parser
On 09/09/2010 09:08 AM, Thomas Goirand wrote:
>> 1) Why not using the "patch" target from
>> /usr/share/dpatch/dpatch.make?
>
> Sorry, I tried "patch-stamp" instead as I wrongly remembered, it
> didn't work, I got pissed, so did like that (too fast, thinking
> wrongly that it was acceptable). I'll upload a fix, thanks for your
> remark.
>
Ok.
>> 2) + * Bumps Standard-Version to 3.9.1.
>>
>> Not needed.
>>
>> 3) + * Added debian/source/format and debian/README.source
>>
>> Not needed.
>>
>
> Other release team members never complained about the above changes,
> and I saw people on IRC saying that 2) was fine, and wild-guessed
> that 3) was ok.
>
People? Never say never (Example: [1]). Besides, acceptable changes are
described in [2].
[1] <[🔎] 20100906182342.GF14205@radis.liafa.jussieu.fr>
[2] <20100903122801.GJ17464@halon.org.uk>
> I'm not saying you are wrong,
Il ne manquerait plus que ça.
> but rather I'm asking: do you want me to reverse these changes, and
> re-upload to SID without them (and the debian/rules change)?
>
It's ok for this upload. No need to revert what's already done. But, be
aware of that for next time.
Regards,
--
Mehdi Dogguy مهدي الدڤي
http://dogguy.org/
Reply to: