[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Freeze exception for xine-lib 1.1.14-2



I demand that Marc 'HE' Brockschmidt may or may not have written...

> Darren Salt <linux@youmustbejoking.demon.co.uk> writes:
>> I demand that Marc 'HE' Brockschmidt may or may not have written...
>>> Darren Salt <linux@youmustbejoking.demon.co.uk> writes:
>>> [xine fixes]
>>>> Uploaded and ready for unblocking...
>>> Unblocked. Will need its 10 days, though.
>> I'm going to have to do another upload: some patches which I've been
>> sitting on (waiting for testing & review) have escaped into public
>> view...

> All fine. Have new patches popped up in the meantime?

Just this (at present), which is reported as fixing a KDE 4 FTBFS.

--- a/src/xine-engine/buffer.h
+++ b/src/xine-engine/buffer.h
@@ -676,7 +676,7 @@ void _x_bmiheader_le2me( xine_bmiheader 
 /* convert xine_waveformatex struct from little endian */
 void _x_waveformatex_le2me( xine_waveformatex *wavex ) XINE_PROTECTED;
 
-static inline _x_is_fourcc(void *ptr, void *tag) {
+static __inline int _x_is_fourcc(void *ptr, void *tag) {
   return memcmp(ptr, tag, 4) == 0;
 }

Any more patches which may be needed I expect to be security bug fixes only;
however, I've just seen one which should improve FLV playback (dummy frames,
metadata handling) but in its current form, it's not acceptable upstream. I
doubt that it'd be acceptable for lenny anyway...

-- 
| Darren Salt    | linux or ds at              | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
|   <URL:http://www.youmustbejoking.demon.co.uk/> (PGP 2.6, GPG keys)

debugging: v. The process of removing bugs caused by programming.


Reply to: