[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please unblock libpng 1.2.15~beta5-0



On Tue, Dec 19, 2006 at 10:16:11AM +0100, Andreas Barth wrote:
>* Andreas Barth (aba@not.so.argh.org) [061219 10:11]:
>>* Steve Langasek (vorlon@debian.org) [061219 09:31]:
>>>On Mon, Dec 18, 2006 at 04:39:49PM +0100, Andreas Barth wrote:
>>>>    2 X+++++++++
>>>
>>>These are the only two symbols that would potentially be a reason to prefer
>>>.13 over .15.
>>
>>Agreed. This are png_read_destroy and png_write_destroy. These packages
>>break:
>>[...]

Those two can be easily put back.

>Anibal, why were these two changes done:
>diff -Nru /tmp/LwlHQys59r/libpng-1.2.13/png.h /tmp/HyqevTMV7t/libpng-1.2.15~beta5/png.h
>--- /tmp/LwlHQys59r/libpng-1.2.13/png.h 2006-12-19 09:10:42.000000000 +0000
>+++ /tmp/HyqevTMV7t/libpng-1.2.15~beta5/png.h   2006-12-08 01:21:09.000000000 +0000
>@@ -1710,8 +1720,7 @@
>    png_ptr_ptr, png_infopp info_ptr_ptr, png_infopp end_info_ptr_ptr));
>
> /* free all memory used by the read (old method - NOT DLL EXPORTED) */
>-/* Debian note: exporting as it is required by legacy applications */
>-extern PNG_EXPORT(void,png_read_destroy) PNGARG((png_structp png_ptr, png_infop info_ptr,
>+extern void png_read_destroy PNGARG((png_structp png_ptr, png_infop info_ptr,
>    png_infop end_info_ptr));
>
> /* free any memory associated with the png_struct and the png_info_structs */
>@@ -1719,8 +1728,7 @@
>    PNGARG((png_structpp png_ptr_ptr, png_infopp info_ptr_ptr));
>
> /* free any memory used in png_ptr struct (old method - NOT DLL EXPORTED) */
>-/* Debian note: exporting as it is required by legacy applications */
>-extern PNG_EXPORT(void,png_write_destroy) PNGARG((png_structp png_ptr));
>+extern void png_write_destroy PNGARG((png_structp png_ptr));
>
> /* set the libpng method of handling chunk CRC errors */
> extern PNG_EXPORT(void,png_set_crc_action) PNGARG((png_structp png_ptr,
>
>
>I couldn't find any documentation about these two changes.

It's my mistake. I can see its consecuences.

Should I prepare a 1.2.15 debian package with the shlibs and the
png.h changes?

>Cheers,
>Andi
>-- 
>  http://home.arcor.de/andreas-barth/

Best Regards,

Aníbal Monsalve Salazar
-- 
http://v7w.com/anibal

Attachment: signature.asc
Description: Digital signature


Reply to: