[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Accepted lesstif1-1 1:0.93.94-11.3 (i386 source all)



On Tue, May 10, 2005 at 08:43:51PM -0400, Joey Hess wrote:
[...]
> This seems broken:
> 
> -           sprintf(buf, "compress > \"%s\"", filename);
> -           if (!(mdata->stream.file = popen(buf, "w")))
> +           snprintf(buf, sizeof(buf), "compress > \"%s\"", filename);
> +           if (!(mdata->stream.file = s_popen(buf, "w")))
[...]
> 
> Another problem with this s_popen is that it doesn't interpolate quotes
> the way the shell does, so calls to s_popen (or popen with the above
> #define) like these all won't work:
[...]

I've fixed these in 1:0.93.94-11.4, and filed #308783 to make sure
libxpm4 gets fixed too.

Thanks,

Matej



Reply to: