Matej Vela wrote: > On Tue, May 10, 2005 at 08:43:51PM -0400, Joey Hess wrote: > [...] > > This seems broken: > > > > - sprintf(buf, "compress > \"%s\"", filename); > > - if (!(mdata->stream.file = popen(buf, "w"))) > > + snprintf(buf, sizeof(buf), "compress > \"%s\"", filename); > > + if (!(mdata->stream.file = s_popen(buf, "w"))) > [...] > > > > Another problem with this s_popen is that it doesn't interpolate quotes > > the way the shell does, so calls to s_popen (or popen with the above > > #define) like these all won't work: > [...] > > I've fixed these in 1:0.93.94-11.4, and filed #308783 to make sure > libxpm4 gets fixed too. Looks ok, however, I think 2 days may be a bit too short delay for this to get to testing due to the number of changes. I will unblock it in 5 days. -- see shy jo
Attachment:
signature.asc
Description: Digital signature