> > I don't understand what sid-addon is. The only reference I can find on > > Google for that term is, uh, this email. > > sid-addon was meant as a (probably confusing) expression for non-free > not being a part of Debian. I meant the non-free directory next to > the sid distribution. Got it. > > The change I'm implementing (which differs from the one in the original > > bug report) is just two lines of code, and is fairly trivial. However, > > I agree that it does not need to go into the r2 update. > > Sounds good. Could you provide the patch? It's attached. I've CC'd the BTS, as well, so there will be a record of it there. I'll upload 4.2.4-9.2 to stable and 4.2.4-13 to unstable soon as I have the time to get the package built on all architectures. That may or may not be tonite. > Computers are not intelligent. They only think they are. Heh. :-) KEN -- Kenneth J. Pronovici <pronovic@debian.org>
Index: compress42.c
===================================================================
RCS file: /opt/public/cvs/debian/ncompress/compress42.c,v
retrieving revision 1.2
retrieving revision 1.2.2.1
diff -u -r1.2 -r1.2.2.1
--- compress42.c 7 Apr 2003 22:50:30 -0000 1.2
+++ compress42.c 17 Nov 2003 00:56:07 -0000 1.2.2.1
@@ -230,6 +230,8 @@
#define INIT_BITS 9 /* initial number of bits/code */
+#define MIN_MAXBITS 10 /* min value for -b maxbits (smaller causes corruption) */
+
#ifndef SACREDMEM
/*
* SACREDMEM is the amount of physical memory saved for others; compress
@@ -820,7 +822,7 @@
nextarg: continue;
}
- if (maxbits < INIT_BITS) maxbits = INIT_BITS;
+ if (maxbits < MIN_MAXBITS) maxbits = MIN_MAXBITS;
if (maxbits > BITS) maxbits = BITS;
if (*filelist != NULL)
Index: debian/changelog
===================================================================
RCS file: /opt/public/cvs/debian/ncompress/debian/changelog,v
retrieving revision 1.1
retrieving revision 1.1.2.1
diff -u -r1.1 -r1.1.2.1
--- debian/changelog 7 Apr 2003 22:50:30 -0000 1.1
+++ debian/changelog 17 Nov 2003 00:56:07 -0000 1.1.2.1
@@ -1,3 +1,9 @@
+ncompress (4.2.4-9.2) unstable; urgency=low
+
+ * Disallow maxbits less than 10, to avoid data corruption (closes: #220820).
+
+ -- Kenneth J. Pronovici <pronovic@debian.org> Sun, 16 Nov 2003 18:32:28 -0600
+
ncompress (4.2.4-9.1) unstable; urgency=low
* NMU based on patch by Stephen Stafford <bagpuss@debian.org>:
Attachment:
pgpP43myL2S_V.pgp
Description: PGP signature