[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#764178: marked as done (debsources: infobox CSS alignment problem with short files)

Your message dated Wed, 5 Nov 2014 15:13:02 +0100
with message-id <20141105141302.GA5911@upsilon.cc>
and subject line Re: Bug#764178: debsources: infobox CSS alignment problem with short files
has caused the Debian Bug report #764178,
regarding debsources: infobox CSS alignment problem with short files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
764178: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764178
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qa.debian.org
Severity: minor
User: qa.debian.org@packages.debian.org
Usertags: debsources

On Mon, Oct 06, 2014 at 09:21:34AM +0200, Ferenc Wagner wrote:
> Your wonderful service seems to have alignment issues displaying short
> files.  In the attached screenshot, the file contents (9) is pushed so
> far to the right that it overlaps with the info box.  Please consider
> fixing this.

Thanks Ferenc,
  I'm forwarding your message to the Debian bug tracking system, so that
we don't lose track of your (very reasonable!) request.

I suspect the reasonable behavior here would be to ensure that the CSS
box showing the file content is always large enough to contain the
package info box --- no matter if the infobox is expanded or not, and no
matter the amount of lines in the file.

Patches from CSS-skilled people that implement such a behavior would be
very welcome!

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader  . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

Attachment: compat_align.png
Description: PNG image


--- End Message ---
--- Begin Message --- 
On Wed, Nov 05, 2014 at 08:33:15AM -0500, Jason Pleau wrote:
> On 05/11/14 07:51 AM, Christophe Siraut wrote:
> > We could instead limit the expansion of the first column, which contains
> > the line numbers, see attachment.
> 
> Looks like that's a better solution ! I had tested with "max-width", it
> didn't work for me. Should have tested with a simple "width" :)

Thanks Christophe for your solution, and Jason for your help in
debugging this matter.

I've locally committed the attached patch and I'm going to push soon
unless you've further comments. Please note that I've reduced the width
to 60px, as that seems to be enough for line numbers in the 10k range,
and doesn't look as bad as 80px on small line numbers. If you think
that's a problem, please shout :-)

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader  . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

--- End Message ---
Reply to: