[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#764178: debsources: infobox CSS alignment problem with short files

First of all: thanks a lot for your patch, Jason!

On Fri, Oct 31, 2014 at 07:42:23AM -0400, Jason Pleau wrote:
> From 6cc9f15d51dd35a5afb82a2c3680e3e5dfc0f93b Mon Sep 17 00:00:00 2001
> From: Jason Pleau <jason@jpleau.ca>
> Date: Fri, 31 Oct 2014 00:05:26 -0400
> Subject: [PATCH] source_file: fix text overlapping the infobox

I'm no CSS expert, so I'm unable to comment on your patch at the
moment. Matthieu: can you have a look and comment on Jason's approach at
fixing #764178.

I've a separate comment though:

> When browsing a file's source on sources.debian.net, if the file
> didn't contain enough text its content would overlap onto the infobox
> to the right.

Your commit message essentially restates the bug report, rather than
explaining how the corresponding change fixes it. The commit message
should really do the latter, rather than the former.

Particularly in this case, I see no obvious reason why changing the
right padding of codetable (an horizontal spacing matter) would fix the
bug (which seems to be a vertical spacing matter). I'm sure it *does*
fix the bug, but the commit should explain why it does so, so that even
CSS illiterates as myself could understand the rationale :-)

Jason: do you think you can update your patch to do so?

Many thanks in advance,
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader  . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

Attachment: signature.asc
Description: Digital signature

Reply to: