Re: pngcrush and bugs 331068, 338659, 355693, 352177, 330026

["Nelson A. de Oliveira" <naoliv@gmail.com>]

Hi!

(I am CCing Alexander)

On 3/28/06, Kapil Hari Paranjape <kapil@imsc.res.in> wrote:
> In the light of Alexander Schmehl's message in this thread on
> debian-qa in March 2005 you may want to adopt pngcrush as a first step.

Is the ITA (#353392) not active?
Alexander said on 23 Mar 2006:

"However, I want be able to upload a fixed package till mid/end of next week."

And also says:

> I can do a QA upload for you, but let's see what Alexander says first.
If you want it, you can have it.

So, is Alexander wanting to adopt the package or not?
If not, you (Kapil), may want to adopt it.

> In case you wish to do so I would be grateful if you built pngcrush
> which uses dynamic libraries as building it with static libraries
> leads to objections from the security team. A small diff that allows
> pngcrush-1.6.2-nolib to compile with dynamic libpng and zlib is
> at
>         http://www.imsc.res.in/~kapil/debian/pngcrush/pngcrush_1.6.2-0.1.diff.gz

Right.
I did some small updates on your diff.
You can see it here:
http://biolinux.df.ibilce.unesp.br/naoliv/pngcrush/pngcrush_1.6.2-0.1.diff.gz
And the interdiff between your diff and mine:
http://biolinux.df.ibilce.unesp.br/naoliv/pngcrush/interdiff.gz

They are just some small fixes that would be good to be included when
uploading a new version of pngcrush.

The only problem that is report by linda is:

$ linda -i pngcrush_1.6.2-0.1_i386.deb
W: pngcrush; A binary links against a library it does not use symbols from
 This package contains a binary that links against a library that is
 not in the Depends line. This may also be a bug in the library which
 does not have a shlibs file.

With lintian it´s clean.

I have to say that I don´t understand this. Today I was running linda
on some packages and I saw this warning. Not only on one package. (If
somebody could explain me this, maybe offlist, please)

Also, it would be better to use separated patches for the changes on
Makefile and pngcrush.c (using dpatch, for example).
So, when a new version of pngcrush is released, we will just need to
copy the debian/ dir (if the patches apply clearly) and there will be
no need to edit those files again.
Just a suggestion.

> I will be happy to co-maintain any/all these packages with you if
> that is what you wish.

Sure! Team maintenance is always good.
As you are seeing here on QA list, we are wanting to merge the PNG
optimizers. I think that we will end with a "PNG optimizer team" :-)

The best to do now, I think, is to upload a new version of pngcrush
(Alexander and/or Kapil).
Then, we will think about contacting the upstream authors, merging
programs, packages, etc.
Right?

Thank you!

Best regards,
Nelson