[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Newer laptops & CPU speed



Hello again, Ben!

you suggested the following change:

On Mon, Mar 14, 2005 at 01:33:42PM +1100, Benjamin Herrenschmidt wrote:
> -	/*  Check for 7447A based iBook G4 or PowerBook */
> -	if (machine_is_compatible("PowerBook6,5") ||
> -	    machine_is_compatible("PowerBook6,4") ||
> -	    machine_is_compatible("PowerBook5,5") ||
> -	    machine_is_compatible("PowerBook5,4")) {
> +	/*  Check for 7447A based MacRISC3 */
> +	if (machine_is_compatible("MacRISC3") &&
> +	    get_property(cpunode, "dynamic-power-step", NULL) &&
> +	    PVR_VER(mfspr(SPRN_PVR)) == 0x8003) {

In pmac_feature.c I find the following lines:

#ifdef CONFIG_CPU_FREQ_PMAC
	/* XXX should be elsewhere */
	if (machine_is_compatible("PowerBook6,5") ||
	    machine_is_compatible("PowerBook6,4") ||
	    machine_is_compatible("PowerBook5,5") ||
	    machine_is_compatible("PowerBook5,4")) {
		struct device_node *volt_gpio_np;
		u32 *reg = NULL;

		volt_gpio_np = of_find_node_by_name(NULL, "cpu-vcore-select");
		if (volt_gpio_np != NULL)
			reg = (u32 *)get_property(volt_gpio_np, "reg", NULL);
                ...

Is a similar change required here?

All the best,
Jochen
-- 
http://seehuhn.de/

Attachment: signature.asc
Description: Digital signature


Reply to: