[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

mol comments



Hi Jens

You're great! It works nicely (after recompiling for my benh kernel)!

Here's my comments after a few minutes of looking into the source and
diff:

Why put debian-mol-modules-source/ in the root? I think it would be nicer
with all Debian/related stuff in debian/.

debian-mol-modules-source/changelog.blanko lacks a newline in the end.

I was hoping you would have made the module-source hooking into
kernel-package to make building it semi-automatic. I haven't figured out
yet just how to do it myself, but if not anything else you could maybe
simply throw it into the TODO :-)

Consider adding the following (just adding the file works out-of-the-box -
or at least it did for me):

--- mol-0.9.57.orig/lib/vmodes/tibook.modes
+++ mol-0.9.57/lib/vmodes/tibook.modes
@@ -0,0 +1,11 @@
+
+mode "1152x768-55"
+    # D: 64.994 MHz, H: 44.154 kHz, V: 54.781 Hz
+    geometry 1152 768 1152 768 8
+    timings 15386 158 26 29 3 136 6
+    hsync high
+    vsync high
+    accel true
+    rgba 8/0,8/0,8/0,0/0
+endmode
+

 - Jonas

-- 
Jonas Smedegaard   <jonas@jones.dk>   http://www.jones.dk/~jonas/
IT-guide dr. Jones    <dr@jones.dk>   http://dr.jones.dk/    +45 40843136
Debian GNU/Linux    <js@debian.org>   http://www.debian.org/
GnuPG(1024D/C02440B8): 9A98 C6EB C098 9ED0 3085  ECA9 9FB0 DB32 C024 40B8




Reply to: