[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Use $DEB_BUILD_DIR rather than parent directory?



On 20-Nov-00, 11:32 (CST), Wichert Akkerman <wichert@valinux.com> wrote: 
> Previously Steve Greenland wrote:
> > I, for one, would like this feature. I'm vastly confused about why it
> > would be a policy issue, though.
> 
> because it means all debian/rules files need to be changed to replace
> 	
> 	dpkg --build debian/tmp ..
> 
> with
> 	dpkg --build debian/tmp $(DEB_BUILD_DIR)
> 

Or just modify dpkg (or actually dpkg-deb, I guess) could be modified
to look for the environment variable DEB_BUILD_DIR and use it if it
was defined, requiring no changes at all to the debian/rules files. I
assumed that was the whole point of the proposal. Since dpkg-deb already
supports an alternative target directory, I can't believe that this is
all that difficult. In fact, here's a (briefly) tested patch:

--- dpkg-1.7.1.1/dpkg-deb/build.c       Tue Aug 22 16:21:59 2000
+++ dpkg-1.7.1.2/dpkg-deb/build.c       Mon Nov 20 12:30:29 2000
@@ -175,13 +175,13 @@
   subdir= 0;
   if ((debar= *argv++) !=0) {
     if (*argv) badusage(_("--build takes at most two arguments"));
-    if (debar) {
-      if (stat(debar,&debarstab)) {
-        if (errno != ENOENT)
-          ohshite(_("unable to check for existence of archive `%.250s'"),debar);
-      } else if (S_ISDIR(debarstab.st_mode)) {
-        subdir= 1;
-      }
+  }
+  if (debar || ((debar = getenv("DEB_BUILD_DIR")) != NULL)) {
+    if (stat(debar,&debarstab)) {
+      if (errno != ENOENT)
+        ohshite(_("unable to check for existence of archive `%.250s'"),debar);
+    } else if (S_ISDIR(debarstab.st_mode)) {
+      subdir= 1;
     }
   } else {
     m= m_malloc(strlen(directory) + sizeof(DEBEXT));


Steve
-- 
Steve Greenland <stevegr@debian.org>
(Please do not CC me on mail sent to this list; I subscribe to and read
every list I post to.)

Attachment: pgp2MzFyx9yEj.pgp
Description: PGP signature


Reply to: