Bug#832704: RFS: nixnote2/2.0~beta8+20160727+ds-1 [ITP] -- Open Source Evernote client
Hello,
2016-08-25 5:41 GMT+08:00 Sean Whitton <spwhitton@spwhitton.name>:
> You claim that the upstream files are only licensed under the GPL
> version 2 (and no later version). But looking at the headers of the .h
> and .cpp files, the upstream author licenses them as GPL-2+. However,
> EnCrypt.java is just GPL-2 with no later version.
Fixed in the copyright file.
Upstream said the entire project is released under GPL-2, but some certain files
are released under GPL-2+. So I am writing that "Files: *" is under GPL-2 and
listed those files to be under GPL-2+.
Personally I have one question: Now that upstream said some files are released
under GPL-2+, is it reasonable for the Debian package to choose only the
GPL-2 license to republish?
> The copyright status of the images/ subdirectory is also unclear.
Besides the purple-theme directory (as stated below), I am willing to believe
that those files are released under GPL-2 as stated by the Nixnote2 author.
> Although the Trolltech license passes DFSG, it is not correct to label
> it as "public domain" because they have claimed copyright on the file.
> Putting something in the public domain is to declaim copyright. So I
> would call the license "custom1" or something.
Fixed as "custom1".
> The address of the FSF offices in screencapture.cpp is not correct. It
> would be best to patch it and submit that upstream. Similarly
> screencapture.h.
Patch sent to upstream as PR (https://github.com/baumgarr/nixnote2/pull/200).
Not accepted yet, but I put it inside debian/patches for now.
The patch will be removed after the PR is merged.
> The copyright status of faderdialog.{cpp,h} needs looking at -- the
> files claim they were taken from some web forum!
Good news: as stated in the forum rule http://www.qtcentre.org/rules/:
"Unless stated otherwise by the author all code published on this site is
public domain and can be used by anyone for anything without any affiliation
to the original author."
No statement was found in the related post, so I have updated the copyright
file as public-domain.
> The qevercloud/ dir seems to be an embedded code copy of ...
OK. Here comes the tough part.
In short: Nixnote2 upstream said he/she is forking and maintaining the
embedded code, qevercloud original upstream dead, no need to worry.
A slightly long story: https://github.com/baumgarr/nixnote2/issues/187
Someone is picking up and forking the project. The qevercloud library
was not made into shared library before (in 2.x series). The new forker
is releasing 3.x releases with shared library support. However, the author
of Nixnote2 is not willing to use the forked codes now.
I made some investigations and find that the code for Nixnote2 needs
slight modifications to use qevercloud 3.x. So far I have tried to pack
libqevercloud* as debian package and some result can be found on
GitHub (https://github.com/hosiet/qevercloud), but I am not going to
file ITP/RFS until upstream agrees to adapt QEvercloud 3.x branch.
> ... generated cpp source files in qevercloud ...
That is generated from Evernote Cloud API Thrift IDL files [1], an abstract
description of Evernote Cloud API, and generated files should be considered
as part of the source code. It is barely impossible and does not make sense
to regenerate those files.
[1] https://github.com/evernote/evernote-thrift , some more stories in
https://blog.evernote.com/tech/2011/05/26/evernote-and-thrift/ .
> There's a further issue with at least some of the files in images/. The
> check-all-the-things tool reveals:
>
> # Check with upstream where the GIMP XCF source files are.
> $ find -type f \( -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' \) -exec grep -iF gimp {} +
> Binary file ./images/purple-theme/synchronize.png matches
>
> i.e. images/purple-theme/synchronize.png was probably created with the
> GIMP. That means the preferred format for modifying this file is
> probably a *.svg file. Similarly, the other files in the theme might
> have been prepared with a tool that works with *.svg files and exports
> to *.png.
>
> In order to satisfy DFSG (and indeed the GPL), the *.svg files need to
> be included in the source package.
Upstream gives no response, and I am patching to move the entire purple
theme away from the source code for now.
Issue sent (https://github.com/baumgarr/nixnote2/issues/201).
Patch added and will be kept or removed after the explanation on this
problem from upstream.
> I think you need to patch readme.txt to remove reference to installation
> instructions, since (rightly) you're not installing install.txt and
> Readme_Arch_Linux.txt.
Patch added.
Not sending patch to upstream, since it is merely a debian-package issue.
> Finally, it seems that spellchecker.cpp hardcodes paths to OpenOffice
> dictionaries in /opt. They're not installed to /opt on Debian. And
> maybe you need a dependency on libreoffice.
The software already has a dependency to libhunspell to provide spell checking
feature with top priority as stated in the source code. I believe
those legacy paths
of OO.o should not cause problems if they still exist in the source code.
Libreoffice is not needed as well, according to the author [2]. So I
am not intended
to fix it.
[2] https://github.com/baumgarr/nixnote2/issues/183#issuecomment-234800970
Plus, some typos in the source code are found and written in the PR
sent to upstream.
OK. Now I believe all copyright-related issues are fixed or explained by now.
The GitHub repository is updated and the new version has been uploaded onto
mentors.debian.net/package/nixnote2.
Let's see if there is any further question :-)
Sinerely,
Boyuan Yang
Reply to: