control: tag -1 +moreinfo
control: owner -1 !
Hello,
Thanks for packaging this. Org-mode >> Evernote but enabling people to
use the latter on Debian might be a useful gateway drug ... and a lot of
people say that Org-mode is the gateway drug for Emacs proper ;)
I can't sponsor the upload, but I hope the following review is useful to
you. I've split it into two sections: things that I would consider
must-fixes before an upload to Debian, and suggested improvements. The
latter aren't strictly necessary, but they would help demonstrate to a
potential sponsor that you are committed to maintaining this package in
Debian.
Since I am not familiar with Java packaging, it would be advisable to
ask on the Debian java packaging group mailing list for someone to
review those parts of the package.
Must-fixes
----------
Is the GitHub repo that this package is based on a fork of Nevernote? I
think you should change the Homepage: field to point at the GitHub
repo. Or are they controlled by the same person?
Your version number indicates that you are packaging a beta release.
Generally, only full upstream releases are uploaded to Debian unstable,
rather than testing releases/release candidates. Is there some good
reason for using this version?
The description of the "exclude opencv linking" doesn't explain why
opencv support is disabled "for now". Please explain.
Vcs-* should point at your packaging repository, not the upstream git
repository.
You should remove the "ignore-branch" and "builder" settings from
gbp.conf. Those should only be set in ~/.gbp.conf or /etc/gbp.conf.
I can't try building and installing this package because I can't get a
correct orig tarball. The version on mentors seems to be out-of-date,
and the version the watch file downloads conflicts with your
<https://github.com/hosiet/nixnote2.git> repo (which is what I'm looking
at). How can I get the correct orig tarball?
Suggested improvements
----------------------
There are a lot of build-dependencies. It would be nice to run
`wrap-and-sort -abst`.
README.Debian is meant for users, but what you have written in there is
only really relevant to Debian contributors. Perhaps rename it to
README.source, or just remove it. You could also cite the relevant
section of policy (and the version of policy in which the section had
that number).
The watch file looks like it will only work for the current version,
because the repack suffix contains a part of the current version
string. Could it be made more general?
Could you explain why you Recommends: mimetex and Suggests: cups?
You're installing README.md but this file contains no useful
information. The README.txt file looks more useful. Does that get
installed to the help/ dir? I couldn't tell without building the
package, sorry!
I'm not sure you need to override dh_installchangelogs. It usually
detects filenames like 'changelog.txt'. But I might be wrong.
At debhelper compat 9, I think that you could remove a lot of lines from
your rules file. For example, you probably don't need these lines:
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/default.mk
include /usr/share/dpkg/buildflags.mk
Since I couldn't actually build the package, that's all for now!
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature