Bug#832704: RFS: nixnote2/2.0~beta8+20160727+ds-1 [ITP] -- Open Source Evernote client
Hello,
2016-08-24 11:56 GMT+08:00 Sean Whitton <spwhitton@spwhitton.name>:
>> Since it is a debian-source (ds) package, I am not sure which original tarball
>> should be provided with pristine-tar. Anyway, I put both the ds-modified and
>> the original tarball with pristine-tar inside now. (Check the
>> pristine-tar branch.)
>
> I meant the tarball that you want to have uploaded to Debian.
Got it. :)
>> FYI, this software is debian-sourced because it used to contain some
>> useless scripts (custom hacky scripts for deb / rpm / targz packaging)
>> and a jar file (which is not acceptable in Java packaging). The
>> ds-version merely delete those files.
>
> You can do this if it's convenient, but you don't need to -- it's only
> non-DFSG-free files that have to be filtered out. You can just not
> install the .jar, which might be easier than making a +ds tarball
> everytime upstream makes a new release.
That would be great. Personally since 2.0~beta9 < 2.0~beta9+ds,
I would like to defer it to next upstream release.
> Also, you could consider using .xz compression for the orig tarball to
> save space on the Debian mirror network. You can set that in gbp.conf
> if you're using gbp to generate tarballs.
Fixed in d/watch, d/gbp.conf and pristine-tar branch.
> On Thu, Aug 11, 2016 at 12:58:00PM +0800, Boyuan Yang wrote:
>> > Is the GitHub repo that this package is based on a fork of Nevernote? I
>> > think you should change the Homepage: field to point at the GitHub
>> > repo. Or are they controlled by the same person?
>>
>> They are controlled by the same person and actually they are the *same
>> project*. Actually the author is still using nevernote page on
>> Sourceforge to distribute pre-built nixnote2 packages.
>
> I filed https://github.com/baumgarr/nixnote2/issues/198
Great, I will track upstream response.
> The opencv patch has now disappeared. Was that deliberate?
Yes. It was merged upstream.
>> > You're installing README.md but this file contains no useful
>> > information. The README.txt file looks more useful. Does that get
>> > installed to the help/ dir? I couldn't tell without building the
>> > package, sorry!
>>
>> I did not install README.txt, since this file mainly describes the situation
>> of source (not the binary). Should I install it anyway?
>
> I was thinking that the index of other documentation might be useful --
> it explains the purpose of theme.ini. shortcut_howto.txt etc.
> colors.txt is an example file so it should go into
> /usr/share/doc/nixnote2/examples.
Sure. It is installed using dh_installexamples(1) now.
> There are some problems with your copyright file:
>
> - You're using an outdated format, and the URI in Format-Specification:
> doesn't work. Please check policy for the current format.
>
> - You need a "Files: *" paragraph, and "icons/*" doesn't need to be a
> separate paragraph.
>
> - You should add yourself to the copyright for debian/*.
>
> - There is a syntax error too :) In the GPL-2+ paragraph.
Hold on, are you looking at upstream copyright file?
That file is outdated and not used. Please check the file on Debian branch:
https://github.com/hosiet/nixnote2/blob/debian/debian/copyright
> - Looks like the manpage is copyright Vincent Cheng.
Fixed.
> Docs go in /usr/share/doc/nixnote2 not /usr/share/nixnote2 -- you're
> installing several to the wrong place, but some to the right place.
Fixed. Now everything other than theme.ini and shortcuts.txt are installed
as docs. The only two files are left because they are shipped as fixed config
files.
> The comments in your d/rules file are great. Have you filed an upstream
> bug about the broken `make install`? You could provide them with your
> d/install file to help.
Thanks, I will file the issue later. This is not of top priority.
Previously upstream did not provide the `make install' target but to rely on
`cp'. That target was added recently from a PR but the quality is poor.
I updated the GitHub repository and dsc package on mentors again.
Sincerely,
Boyuan Yang
Reply to: