Hello,
On Wed, Aug 24, 2016 at 03:57:36PM +0800, Boyuan Yang wrote:
> >> FYI, this software is debian-sourced because it used to contain some
> >> useless scripts (custom hacky scripts for deb / rpm / targz packaging)
> >> and a jar file (which is not acceptable in Java packaging). The
> >> ds-version merely delete those files.
> >
> > You can do this if it's convenient, but you don't need to -- it's only
> > non-DFSG-free files that have to be filtered out. You can just not
> > install the .jar, which might be easier than making a +ds tarball
> > everytime upstream makes a new release.
>
> That would be great. Personally since 2.0~beta9 < 2.0~beta9+ds,
> I would like to defer it to next upstream release.
That sounds fine.
> > The opencv patch has now disappeared. Was that deliberate?
>
> Yes. It was merged upstream.
Cool.
> >> > You're installing README.md but this file contains no useful
> >> > information. The README.txt file looks more useful. Does that
> >> > get installed to the help/ dir? I couldn't tell without building
> >> > the package, sorry!
> >>
> >> I did not install README.txt, since this file mainly describes the situation
> >> of source (not the binary). Should I install it anyway?
> >
> > I was thinking that the index of other documentation might be useful --
> > it explains the purpose of theme.ini. shortcut_howto.txt etc.
> > colors.txt is an example file so it should go into
> > /usr/share/doc/nixnote2/examples.
>
> Sure. It is installed using dh_installexamples(1) now.
Good.
> > There are some problems with your copyright file:
> >
> > - You're using an outdated format, and the URI in Format-Specification:
> > doesn't work. Please check policy for the current format.
> >
> > - You need a "Files: *" paragraph, and "icons/*" doesn't need to be a
> > separate paragraph.
> >
> > - You should add yourself to the copyright for debian/*.
> >
> > - There is a syntax error too :) In the GPL-2+ paragraph.
>
> Hold on, are you looking at upstream copyright file?
> That file is outdated and not used. Please check the file on Debian branch:
>
> https://github.com/hosiet/nixnote2/blob/debian/debian/copyright
I was looking at the wrong file -- sorry for being sloppy and wasting
your time. Unfortunately, there are some problems with the one you've
linked to.
You claim that the upstream files are only licensed under the GPL
version 2 (and no later version). But looking at the headers of the .h
and .cpp files, the upstream author licenses them as GPL-2+. However,
EnCrypt.java is just GPL-2 with no later version.
The copyright status of the images/ subdirectory is also unclear. For
example, images/purple-theme/purpleThemeInfo.html says that they were
made by Lexi Shriner. Perhaps confirm with upstream that they are GPL-2
(as license.html would suggest).
Although the Trolltech license passes DFSG, it is not correct to label
it as "public domain" because they have claimed copyright on the file.
Putting something in the public domain is to declaim copyright. So I
would call the license "custom1" or something.
The address of the FSF offices in screencapture.cpp is not correct. It
would be best to patch it and submit that upstream. Similarly
screencapture.h.
The copyright status of faderdialog.{cpp,h} needs looking at -- the
files claim they were taken from some web forum!
The qevercloud/ dir seems to be an embedded code copy of
https://github.com/mgsxx/QEverCloud or one of its GitHub forks, since
that one claims to be inactive. I think you need to package it
separately. qevercloud/generated/* should probably be regenerated at
package build time.
> > Docs go in /usr/share/doc/nixnote2 not /usr/share/nixnote2 -- you're
> > installing several to the wrong place, but some to the right place.
>
> Fixed. Now everything other than theme.ini and shortcuts.txt are installed
> as docs. The only two files are left because they are shipped as fixed config
> files.
Good.
> > The comments in your d/rules file are great. Have you filed an
> > upstream bug about the broken `make install`? You could provide
> > them with your d/install file to help.
>
> Thanks, I will file the issue later. This is not of top priority.
> Previously upstream did not provide the `make install' target but to rely on
> `cp'. That target was added recently from a PR but the quality is poor.
Okay, good to know. Agreed that it is low priority.
In summary -- the package is in great shape, and the only issues are the
copyright and licensing stuff above, plus packaging QEverCloud. Great
work so far.
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature