On 08/24/2016 09:07 PM, Jörg Frings-Fürst wrote:
> My changes:
>
> * New upstream release:
> - debian/control:
This changelog entry suggests that the change in debian/control is part of the new
upstream release. Is that actually the case? If not, the changelog entry should
look like this:
* New upstream release.
* debian/control:
- Add libtool-bin to Build-Depends
Also, I usually prefer to include a minimal explanation as to *why* a certain change
was made. At first glance, it's not very obvious why libtool-bin was added to B-D.
Good changelog entries will always help other maintainers and reviewers to quickly
understand changes and in the case of a regression due to a new package revision
it allows to help reverting any breaking changes very quickly.
As for sponsors like me, a well documented changelog makes reviews less painful and
speeds them up dramatically which is also in the interest of the mentoree as I basically
just need to go through the bullet points in the changelog entry for the latest version,
ack them if they are ok and build and upload the package.
So, please, write good changelogs!
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Attachment:
signature.asc
Description: OpenPGP digital signature