[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#809520: RFS: trend/1.2-2

On Fri, Jan 01, 2016 at 02:28:30PM +0100, Yuri D'Elia wrote:
> On 01/01/16 01:32, Mattia Rizzolo wrote:
> > I'd rather look up where you got the .orig.tar.gz file, gbp doesn't
> > really deal with it here.
> Even when pristine-tar is enabled?
> pristine-tar isn't [yet] in this case, as I used import-dscs.

pristine-tar has its own issues, but it's usually trustable, yes.
but I believe you just used a different tarball while doing this, after
6 years.

> > I mean, of course I'm just going to use the one already in the archive
> > for this, and you don't need to use -sa in this case (given that this is
> > -2 and the file is already in the archive, everything is going to just
> > use that), but I find worrying/weird that you have a different file.
> mentors doesn't accept an upload without source (I was refused while
> doing so), so I'm forced to do this here.

ah, ok (didn't remember such detail, sorry, but it makes sense)

> >>>   + why did you add -Dsrc to the dh command?
> >>
> >> The main Makefile is inside src/, and I'd avoid to use override_ for
> >> most targets. Do you have a better suggestion?
> By the way, the current dh manpage uses --sourcedirectory (I cannot find
> -D anymore), so I'm using that now.

it's in debhelper(7):

       -Ddirectory, --sourcedirectory=directory
                  Assume that the original package source tree is at the
                  specified directory rather than the top level
                  directory of the Debian source package tree.

> I'm also a bit thorn about the dh_installchangelogs override.
> I now install NEWS with the regular debian/docs.

That menas the upstream changelog is going to be installed with a
different name, and that's against the debian policy:

(unstable)mattia@chase ~/devel/RFS/trend % debdiff 1/trend_1.2-2_amd64.deb 2/trend_1.2-2_amd64.deb
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-rw-r--r--  root/root   /usr/share/doc/trend/NEWS.gz

Files in first .deb but not in second
-rw-r--r--  root/root   /usr/share/doc/trend/changelog.gz

See policy 12.7:

"If an upstream changelog is available, it should be accessible as
/usr/share/doc/package/changelog.gz in plain text."

So, please revert this.

> >>> and btw, before me becoming DD I learned to push the debian/ tags to git
> >>> only once the package is uploaded (otherwise now you'll need to
> >>> overwrite it...)
> >>
> >> I didn't realize this was a possibility.
> >> It's my first time using both collab-maint and gbp.
> > 
> > don't worry :)
> So what's the policy about fixing this (and the above) in the for the
> future repository? I mean, should I squash useless history?

no, please don't squash the history, just remove the tag, and redo it
once the package is uploaded, to the correct point of the upload.

> Updated the source, deleted the old tag (for now), and uploaded again on
> mentors.

I also think you errounsly uploaded to ftp-master, didn't you? :)

                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply to: