[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#809520: RFS: trend/1.2-2

On Fri, Jan 01, 2016 at 01:22:53AM +0100, Yuri D'Elia wrote:
> On 01/01/16 01:12, Mattia Rizzolo wrote:
> > though, I'm not satisfied yet:
> > * the orig.tar.gz you used to build this release is different than the
> >   one in the archive.  it's bigger.  I haven't checked why, but I just
> >   can't upload it.
> I suspect because my connection is flaky, and had to dput twice
> (probably between an incoming scan). I'll have a check. I'm using gbp
> buildpackage -sa, so I do not expect issues.

bad connection ain't an excuse: the checksum and the size of the orig
file reported in the .dsc files of the -1 version in the archive, and
the -2 on mentors differs.

1.2-1: fa0a66bab47266d878efd8c5197194473678fbd575e8a318d3714d62c191b0a4 34840 trend_1.2.orig.tar.gz
1.2-2: 848d916331a5f4f531ea62a85dfa2577d545518b5753334d36827e491b540940 35357 trend_1.2.orig.tar.gz

I'd rather look up where you got the .orig.tar.gz file, gbp doesn't
really deal with it here.
I mean, of course I'm just going to use the one already in the archive
for this, and you don't need to use -sa in this case (given that this is
-2 and the file is already in the archive, everything is going to just
use that), but I find worrying/weird that you have a different file.

> >   + why did you add -Dsrc to the dh command?
> The main Makefile is inside src/, and I'd avoid to use override_ for
> most targets. Do you have a better suggestion?

no, it's fine, the point is: <snip, meh, bad me :(>
sorry :\, ignore this point: looking at the debdiff too quickly I read
it and seemed you added it with this upload, which is not the case.

> > and btw, before me becoming DD I learned to push the debian/ tags to git
> > only once the package is uploaded (otherwise now you'll need to
> > overwrite it...)
> I didn't realize this was a possibility.
> It's my first time using both collab-maint and gbp.

don't worry :)

> I'll have a go at the rest and ping you when it's ready.

take you time, and thanks for doing it!

                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply to: