[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754463: RFS: pdf2htmlex/0.11+ds-1



* Johannes Schauer <j.schauer@email.de>, 2014-07-28, 07:18:
The DEP-8 tests fail here. I see lots of errors like this:

Error: Cannot open file /home/jwilk/pdf2htmlex-0.11+ds/share/base.min.css for embedding
Command return code 1: /usr/bin/pdf2htmlEX --data-dir /home/jwilk/pdf2htmlex-0.11+ds/share --dest-dir /tmp/tmpTajvy6 /home/jwilk/pdf2htmlex-0.11+ds/test/test_data/2-pages.pdf

I suppose you shouldn't pass --data-dir when testing the installed version.

I do not understand why it fails for you but not for me.

How did you run the tests? I ran sadt(1) in the freshly-unpacked source tree.

Nevertheless I fixed this by overriding the --data-dir path with an environment variable as well.

I still think it would be better not to pass --data-dir at all.

Unlike build-time tests, as-installed tests have the capability of verifying that all the required files are installed, and that they are installed in a place where the software actually expects them. Let's not ruin this advantage by instructing the software where WE expect the files to be. :-)


Could you set HOME to a non-existent directory in the test script, just like you did in d/rules?

Could you remove the “The information above should follow the Patch Tagging Guidelines …” template from d/p/control-test-executable-name?

Have you seen this thread on d-devel@?
https://lists.debian.org/53CCF007.6020002@debian.org

--
Jakub Wilk


Reply to: