Bug#754463: RFS: pdf2htmlex/0.11+ds-1
Hi,
Quoting Jakub Wilk (2014-07-28 23:08:11)
> >I do not understand why it fails for you but not for me.
>
> How did you run the tests? I ran sadt(1) in the freshly-unpacked source
> tree.
I ran `adt-run -o /tmp/log --source pdf2htmlex_0.11+ds-1.dsc --- schroot sid-amd64-sbuild`
Both invocations work now.
> >Nevertheless I fixed this by overriding the --data-dir path with an
> >environment variable as well.
>
> I still think it would be better not to pass --data-dir at all.
>
> Unlike build-time tests, as-installed tests have the capability of
> verifying that all the required files are installed, and that they are
> installed in a place where the software actually expects them. Let's not
> ruin this advantage by instructing the software where WE expect the
> files to be. :-)
Your reasoning makes lots of sense. I changed things accordingly.
> Could you set HOME to a non-existent directory in the test script, just
> like you did in d/rules?
Done.
> Could you remove the “The information above should follow the Patch
> Tagging Guidelines …” template from d/p/control-test-executable-name?
Woops... thanks for noticing!
I uploaded the new version to mentors.
> Have you seen this thread on d-devel@?
> https://lists.debian.org/53CCF007.6020002@debian.org
Yes, but how is it relevant to this?
cheers, josch
Reply to: