[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754463: RFS: pdf2htmlex/0.11+ds-1



Hi,

Quoting Jakub Wilk (2014-07-16 21:21:15)
> Now --download-current-version is broken:
> 
> $ uscan --download-current-version --destdir .
> uscan warning: In debian/watch no matching hrefs for version 0.11 in watch line
>   https://github.com/coolwanglu/pdf2htmlEX/releases .*/v(\d[\d\.]*)\.tar\.gz
> It think you need to drop dversionmangle to fix it.

you are right! Though it is quite strange that `uscan --destdir .
--force-download` works and `uscan --download-current-version --destdir .` does
not.

On the other hand I now better understand how version mangling works. I indeed
needed to remove dversionmangle. This kept working because uversionmangle will
also mangle the links from the upstream site. So now instead of adapting the
Debian version to be the upstream version (by removing +ds) the upstream
version is adapted to the Debian version (by adding +ds).

What do we do about debian-watch-file-should-dversionmangle-not-uversionmangle
until #753772 is fixed? Ignore it or create an override?

> >If that is all, then all then I only need somebody to sponsor this :)
> 
> Do you mean _me_? It's been less than a weak, I haven't even warmed up 
> yet. ;-P

good to hear - that means many more suggestions will be coming my way :)

> I noticed that when you run pdf2htmlEX for the first time, ~/.FontForge/ gets
> created. This is not itself a problem (even though personally I hate dotfiles
> with passion). The problem is that it will also happen at build time, thanks
> to the test suite. Creating dotfiles at build time is a no-no. I guess the
> simplest way to fix it is to set HOME to something non-existent in
> debian/rules.

Is creating files outside the build directory and not in $TMPDIR a policy
violation?

I already gather statistics of file system access using the machinery to find
unused build dependencies (the thing I wrote about on d-devel). But the
gathered data could easily be used to find this kind of things as well. Would
that make sense?

I would have to adapt the call to sbuild though because by default, sbuild sets
$HOME to /sbuild-nonexistent and thus, no dotfiles are created.

Anyways, I set $HOME to a nonexistant directory in debian/rules.

> I think it would be good to add a comment to d/copyright explaining that
> upstream clarified the license; or maybe cherry pick the commit:
> https://github.com/coolwanglu/pdf2htmlEX/commit/6e8d5396cdad Currently it
> might be not obvious to a person who didn't read this RFS thread (such as
> ftp-master) that your copyright matches upstream intentions.

Correct. I cherry picked the relevant parts of the upstream commit.

> I see you have lots of patches. Which of them are upstreamable? Which of them
> have been already forwarded? You can answer the questions by adding
> appropriate Forwarded: headers to the patches. :-)

All done. :)

cheers, josch


Reply to: