Bug#754463: RFS: pdf2htmlex/0.11+ds-1
Hi,
Quoting Jakub Wilk (2014-07-26 18:35:23)
> * Johannes Schauer <j.schauer@email.de>, 2014-07-26, 12:37:
> >upstream responded and I updated their name with the one they told me.
>
> Perhaps also update patch headers?
Done.
> >I used the (fairly incomplete) testsuite of pdf2htmlEX to run a DEP-8
> >test.
>
> The DEP-8 tests fail here. I see lots of errors like this:
>
> Error: Cannot open file /home/jwilk/pdf2htmlex-0.11+ds/share/base.min.css for embedding
> Command return code 1: /usr/bin/pdf2htmlEX --data-dir /home/jwilk/pdf2htmlex-0.11+ds/share --dest-dir /tmp/tmpTajvy6 /home/jwilk/pdf2htmlex-0.11+ds/test/test_data/2-pages.pdf
>
> I suppose you shouldn't pass --data-dir when testing the installed
> version.
I do not understand why it fails for you but not for me. Nevertheless I fixed
this by overriding the --data-dir path with an environment variable as well.
> I don't think the patch description is grammatically correct. I believe that
> instead of “Allow to control …”, it should be “Allow us to control …” or
> “Allow controlling …”.
It seems that the word "allow" allows both, gerund and infinitive to follow it.
Either should be grammatically fine. I changed it nevertheless to "Allow
controlling" because I don't have a strong opinion on this.
cheers, josch
Reply to: