Hi Andrew,
Thank you for your review !
> I haven't gotten a chance to look at this very deeply yet.
No problem, it's already very nice to spare time to review this package ! :)
I've also spoken with Axel (Beckert), and he signaled me other bugs. So, the
quality of this package should be better now.
> A quick look suggests that the License filed in debian/copyright
> for the upstream files should be GPL-2+ instead of just GPL-2.
I've updated d/copyright to change it.
> It also fails to build for me in a clean sid pbuilder:
The build-dependencies were wrong. I had not tried to build the package with
pbuilder ! Now, it builds fine.
> And finally, you seem to have renamed the binary but not the Exec
> field in the desktop file, so that will be broken.
Added to name.patch. ;)
So... I've made many changes, and, to make clearer, I've written a changelog:
* d/rules:
- Deleted all declarations that debhelper 8 needed which are useless
with debhelper 9.
* d/control:
- Changed debhelper required version to 9.0.0.
- Added new build-dependencies.
* d/compat:
- Using compatibility level 9.
* d/qtop.1:
- Deleted the paragraph about 'info qtop' which was useless.
* d/patches/name.patch:
- Added Top.desktop to the patch.
* d/copyright:
- Changed upstream license from GPL-2 to GPL-2+.
Regards,
Hugo
--
Hugo Lefeuvre (hugo6390) | www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
Attachment:
signature.asc
Description: Digital signature