Bug#749213: RFS: qtop/2.2.3-2 [ITP]

[Andrew Starr-Bochicchio <asb@debian.org>]

On Tue, Jun 10, 2014 at 5:19 AM, Hugo Lefeuvre <hugo6390@orange.fr> wrote:
> Hi,
>
> I've spoken with the Upstream to find a good name. He have also made a
> new version of the software to allow other binary names (2.2.4).
>
> The final name of this package is qtop: I've also made an update, and, finally,
> the package seems ready to be uploaded. qtop appears to be Lintian
> errors/warnings clear and compiles fine on my computer. :)

Hi Hugo,

I haven't gotten a chance to look at this very deeply yet. A quick
look suggests that the License filed in debian/copyright for the
upstream files should be GPL-2+ instead of just GPL-2. It also fails
to build for me in a clean sid pbuilder:

------------------------------
 debian/rules build
dh build
   dh_testdir
   dh_auto_configure
mkdir -p obj-x86_64-linux-gnu
cd obj-x86_64-linux-gnu
cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON
-DCMAKE_BUILD_TYPE=None
-- The C compiler identification is GNU 4.8.3
-- The CXX compiler identification is GNU 4.8.3
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
CMake Error at /usr/share/cmake-2.8/Modules/FindQt4.cmake:1386 (message):
  Found unsuitable Qt version "" from NOTFOUND, this code requires Qt 4.x
Call Stack (most recent call first):
  base/CMakeLists.txt:17 (FIND_PACKAGE)


-- Configuring incomplete, errors occurred!
See also "/tmp/buildd/qtop-2.2.4/obj-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log".
dh_auto_configure: cmake .. -DCMAKE_INSTALL_PREFIX=/usr
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None returned exit code
1
debian/rules:11: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
--------------------------------


And finally, you seem to have renamed the binary but not the Exec
field in the desktop file, so that will be broken.

Thanks for your work on Debian!