[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libengsas packages



Hi,


On 02/25/2013 07:52 AM, Joachim Langenbach wrote:
>> 1) changelog says, that you are targeting the software to "stable"
>> release. It is impossible. Use "unstable" instead. Also you should put
>> your name there.
> 
> So this stable or unstable line refers to the distribution status the package 
> is build for? Like build for squeeze is stable and build for sid is unstable?

Please, check that.

http://www.debian.org/doc/manuals/maint-guide/dreq.en.html#changelog

>> 5) Depends-section contains a lot of libraries, they should be
>> "automatically" picked up due to dh_shlibdeps, if it is possible.
> 
> Without the dependencies to binary packages defined in this package (like 
> dependency of libengsas0-common from libengsas0), right?

Please, check that:

http://www.debian.org/doc/manuals/maint-guide/advanced.en.html#library

Игорь is right,  libengsas0-common should be kept.

For example. there is a list of of dependencies auto-generated by
dh_shlibdeps  for this library:

libc6 (>= 2.2.5), libengsas0, libgcc1 (>= 1:4.1.1), libqt4-network (>=
4:4.5.3), libqt4-sql (>= 4:4.5.3), libqt4-xml (>= 4:4.5.3),
libqt4-xmlpatterns (>= 4:4.5.3), libqtcore4 (>= 4:4.7.0~beta1),
libqtgui4 (>= 4:4.5.3), libstdc++6 (>= 4.1.1)

>> 7) Remove postinst and postrm scripts. Review other ones.
> 
> I had added them, because lintian complains, that they are not there 
> otherwise, is this wrong? Or do you mean a specific one?

Some of your scripts are empty. They should be removed.
Other ones should be reviewed. If you do not really need them - remove them,

Cheers,

Anton

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: