[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libengsas packages



Hi Anton,

thanks for your review. Since I did not understand the reason for some of 
them, I have some questions.

> 1) changelog says, that you are targeting the software to "stable"
> release. It is impossible. Use "unstable" instead. Also you should put
> your name there.

So this stable or unstable line refers to the distribution status the package 
is build for? Like build for squeeze is stable and build for sid is unstable?

> 2) compat-level 7 is relatively old. Use 9 instead.
> 3) control-file has a lot of commented lines. Clean them.
> 4) Current Standards-Version is 3.9.4 now.

I will fix this.

> 5) Depends-section contains a lot of libraries, they should be
> "automatically" picked up due to dh_shlibdeps, if it is possible.

Without the dependencies to binary packages defined in this package (like 
dependency of libengsas0-common from libengsas0), right?

> 6) Copyright-file must be in DEP-5 format.

Ok

> 7) Remove postinst and postrm scripts. Review other ones.

I had added them, because lintian complains, that they are not there 
otherwise, is this wrong? Or do you mean a specific one?

> 8) Use source-format 3.0 (quilt)
> 9) Use --parallel option in dh for faster building.

Very good hint!

> 10) lintian with "-IE --pedantic" over the built package gives a lot of
> warnings, which need to be fixed (see attachment).

Thanks, I run linitan without those flags.

> 11) Did you try to reach Debian Qt/KDE Maintainers? It is better to ask
> them to upload this package and maybe you consider maintaining the
> package under their roof.

I will ask them.

Kind regards,

Joachim


> 
> 
> As said, it is better to discuss a sponsorship question with Debian
> Qt/KDE maintainers.
> 
> Best Regards,
> 
> Anton
> 
> [1] http://pkg-kde.alioth.debian.org/qtkde.html
> 
> On 02/24/2013 11:12 AM, Joachim Langenbach wrote:
> > Dear debian developers,
> > 
> > I'm looking for a sponsor for my libengsas packages. It is a Qt based
> > library, which main goal is to provide platform independend and common
> > API for using KDE libs or Qt only. For example it provides a QFileDialog
> > replacement, which uses the KFileDialog when KDE is enabled or
> > QFileDialog if not. Also the KDE mimetype system can be used. It also
> > provides many base classes, which might be useful for some projects, like
> > a SQL database setup and backup wizard and some chart widgets.
> > 
> > The packages can be found at the open suse build service at
> > https://build.opensuse.org/package/binaries?package=LibEngsas&project=home
> > %3Aengsas&repository=Debian_6.0. There you'll find the following 5 binary
> > packages (beside the sources):
> > 
> > - libengsas0                           The libengsas Qt only version
> > - libengsas0-kde                    The KDE version of libengsas
> > - libengsas0-common            The shared stuff of libengsas and
> > libengsas-kde - libengsas0-dev                    Development files for
> > both libengsas libs - libengsas0-dev-doc             API documentation of
> > libengsas
> > 
> > I'll tried to fix all linitan errors, but I've overrided some also, if
> > they
> > could not be applied in this specific case at my oppinion (documented in
> > the lintian override files).
> > 
> > It would be very nice, if someone may have a look at the packages and give
> > some hints.
> > 
> > Kind regards,
> > 
> > Joachim Langenbach


Reply to: