[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#672654: new version



* Alessandro Ghedini <al3xbio@gmail.com> [120908 14:21]:
> It looks pretty much ready to be uploaded, but I have a couple more comments
> (just nitpicking):
> 
> * it'd be better to add a few more DEP3 [0] headers to the patch.
>   I was thinking of just "Forwarded: not-needed" to make clear that it is
>   Debian-only (if it actually is, "Forwarded: no" otherwise) and "Origin:
>   vendor", to make it clear that it comes from Debian and not upstream.
> 
>   Also, to make it uniform with other team's packages and remove some cruft,
>   could you please "quilt refresh" it with the options "--no-timestamps
>   --no-index -pab"? To make this easier (and future-proof) you can just put the
>   following in your ~/.quiltrc:
> 
>     QUILT_DIFF_ARGS="--no-timestamps --no-index -pab"
>     QUILT_REFRESH_ARGS="--no-timestamps --no-index -pab"
> 
>   and then run:
> 
>     QUILT_PATCHES=debian/patches quilt push -a && quilt refresh

I removed quilt cruft and added patch headers. I didn't know about
these options, thanks for the hint.

I used gbp-pq to build this patch, do you know if there is a way to
make it output a compatible format ? otherwise I'll just use plain
quilt in the future.

> * IMO it makes more sense to build the documentation in the "build"
>   (just after dh_auto_build) target, instead of before dh_installdocs.

You're right. I moved it to dh_override_auto_build and my changes to
alioth.

-- 
Etienne Millon


Reply to: