On Sat, Sep 08, 2012 at 12:59:41PM +0200, Etienne Millon wrote:
> * Alessandro Ghedini <al3xbio@gmail.com> [120907 20:26]:
> > Also, there's no need to re-upload the package to mentors.d.n every
> > time since I use git anyway (same for the debdiff), just ping me
> > when you are done.
>
> This workflow is way simpler, we should do that more often in the
> games team.
>
> I pushed the changes to alioth :
>
> New url : git+ssh://git.debian.org/git/pkg-multimedia/glyr.git
> master at this time : 6511f92
>
> Please tell me what you think.
It looks pretty much ready to be uploaded, but I have a couple more comments
(just nitpicking):
* it'd be better to add a few more DEP3 [0] headers to the patch.
I was thinking of just "Forwarded: not-needed" to make clear that it is
Debian-only (if it actually is, "Forwarded: no" otherwise) and "Origin:
vendor", to make it clear that it comes from Debian and not upstream.
Also, to make it uniform with other team's packages and remove some cruft,
could you please "quilt refresh" it with the options "--no-timestamps
--no-index -pab"? To make this easier (and future-proof) you can just put the
following in your ~/.quiltrc:
QUILT_DIFF_ARGS="--no-timestamps --no-index -pab"
QUILT_REFRESH_ARGS="--no-timestamps --no-index -pab"
and then run:
QUILT_PATCHES=debian/patches quilt push -a && quilt refresh
* IMO it makes more sense to build the documentation in the "build"
(just after dh_auto_build) target, instead of before dh_installdocs.
Cheers
--
perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
Attachment:
signature.asc
Description: Digital signature