[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#672654: new version



On Fri, Sep 07, 2012 at 05:11:00PM +0200, Etienne Millon wrote:
> > debian/rules:
> >  * as per #641051 there is no out-of-the-box  multi-arch support for cmake in
> >    debhelper, but I have noticed that glyr's CMakeLists.txt uses the
> >    INSTALL_LIB_DIR to set that library installation path. Could you please make
> >    use of it to set a multi-arch enabled installation path and then add the
> >    relevant d/control fields [2]?
> > 
> >    The implementation would look something like this (not tested):
> > 
> >      override_dh_auto_configure:
> >      	dh_auto_configure -- -DINSTALL_LIB_DIR=lib/$(DEB_BUILD_MULTIARCH)
> > 
> >    (see also dpkg-architecture(1))
> 
> I did this. The recipe in [2] was perfect :)t 
> 
> > [2] http://wiki.debian.org/Multiarch/Implementation

You should also add Multi-Arch: same headers to -dev and -dbg. AFAICT they are
multi-arched already.

> > There may be other stuff that I didn't notice, but that's all for now.
> 
> Thanks again for your review.
> 
> I pushed & reuploaded the package, it is still available at the same
> URL :
> 
> http://mentors.debian.net/debian/pool/main/g/glyr/glyr_1

I have been playing with libglyr and I noticed that header files of libcurl,
glib and sqlite3 are needed to use libglyr-dev. In fact libglyr.pc Requires
them. It may be a good idea to add them to libglyr-dev Depends.

Also, there's no need to re-upload the package to mentors.d.n every time since I
use git anyway (same for the debdiff), just ping me when you are done.

Cheers

-- 
perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'

Attachment: signature.asc
Description: Digital signature


Reply to: