On Wed, Aug 22, 2012 at 02:25:37PM +0200, Etienne Millon wrote:
> Hello,
Hi,
> I updated my package to version 1.0.0 which was released last month.
> This is obviously not for wheezy. If anyone has any remarks, please do
> so.
>
> The package is available on mentors :
>
> http://mentors.debian.net/debian/pool/main/g/glyr/glyr_1.0.0-1.dsc
I had a look at your package and it mostly looks good, altough I have a few
remarks:
debian/control:
* is there any reason for the Priority: extra? If not it would be better to
change it to optional.
* you are using git and alioth, which is good, but the alioth repository is
placed under your home which is not that good. You may want to join the
collab-maint group [0] or alternatively the Debian Multimedia Team and
maintain this package under its umbrella (which would provide additional
people to help you maintain/upload your package). If you are interested
please read [1] and let me know your alioth username (or send a request to
join yourself).
debian/copyright:
* in the GPL-3+ text, before the last paragraph, there is an additional dot
that should be removed.
debian/rules:
* as per #641051 there is no out-of-the-box multi-arch support for cmake in
debhelper, but I have noticed that glyr's CMakeLists.txt uses the
INSTALL_LIB_DIR to set that library installation path. Could you please make
use of it to set a multi-arch enabled installation path and then add the
relevant d/control fields [2]?
The implementation would look something like this (not tested):
override_dh_auto_configure:
dh_auto_configure -- -DINSTALL_LIB_DIR=lib/$(DEB_BUILD_MULTIARCH)
(see also dpkg-architecture(1))
I have also noticed that some form of API documentation is provided (via
gtk-doc or similar) but it is not built, any reason?
There may be other stuff that I didn't notice, but that's all for now.
Cheers
[0] http://wiki.debian.org/Alioth/PackagingProject
[1] http://wiki.debian.org/DebianMultimedia/DevelopPackaging
[2] http://wiki.debian.org/Multiarch/Implementation
--
perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
Attachment:
signature.asc
Description: Digital signature