Bug#660162: RFS: tack/1.07-2

[Samuel Bronson <naesten@gmail.com>]

On Sat, Feb 25, 2012 at 7:16 PM, Jakub Wilk <jwilk@debian.org> wrote:
> * Samuel Bronson <naesten@gmail.com>, 2012-02-24, 18:32:
>>
>> http://mentors.debian.net/debian/pool/main/t/tack/tack_1.07-1~mentors3.dsc
>
> Arno is breaking mentors.d.n at the moment, so I took a look at git
> repository instead. (I'm assuming it's up to date…)
>
>>  * Re-add debian/watch file (was dropped in 1.06-3).
>>   + Enable uupdate.
>
> As I said on IRC, uupdate is a no-no for me.
>
>>  * Use dh-autoreconf to regenerate the configure script during build
>>   + Build-depends on dh-autoreconf and autoconf-dickey.
>>   + This also takes care of pulling up-to-date config.guess and config.sub
>>     scripts in from autotools-dev.
>
> Are you sure? As far as I can see it doesn't do that:
>
> $ ls -l config.{sub,guess}
> -rwx------ 1 jwilk users 44941 Nov 20  2009 config.guess
> -rwx------ 1 jwilk users 34423 Nov 20  2009 config.sub
>
> $ dh_autoreconf autoreconf-dickey -- -f -i
>
> $ ls -l config.{sub,guess}
> -rwx------ 1 jwilk users 44941 Nov 20  2009 config.guess
> -rwx------ 1 jwilk users 34423 Nov 20  2009 config.sub
>
>>     - DEB_LDFLAGS_MAINT_APPEND for the rest.
>
> DEB_*_MAINT_* were added to dpkg-buildflags in 1.16.1, so you need a
> versioned build-dep for that.

Okay, I fixed those things now:

    http://mentors.debian.net/debian/pool/main/t/tack/tack_1.07-1~mentors5.dsc

tack (1.07-1~mentors5) unstable; urgency=low

  * New upstream release.
  * Adopt package.
    Closes: #660140 (ITP for this package).
  * Switch to dpkg-source 3.0 (quilt) format.
  * Fix "hyphen-used-as-minus-sign" warning from lintian.
  * Re-add debian/watch file (was dropped in 1.06-3).
  * Enable build warnings.
  * Add Vcs-Browser: and Vcs-Git: fields to debian/control.
  * Install a symlink CHANGES.gz -> changelog.gz in the doc directory.
  * Update debian/copyright to final DEP5 format.
  * Use dh-autoreconf to regenerate the configure script during build
    + Build-depends on dh-autoreconf and autoconf-dickey.
    + This also takes care of pulling up-to-date config.guess and config.sub
      scripts in from autotools-dev.
    + ... except with autoconf-dickey it doesn't, so use autotools-dev's
      dh_ commands; bump build-depends to autotools-dev (>= 20100122.1)
      accordingly.  (Yes, even though it says "Do NOT" in the autools-dev
      README.Debian.gz.)
  * Add support for dpkg-buildflags(1) by bumping debhelper compatibility
    level (and build-depends) to 9.
    + Drop the LDFLAGS="-Wl,-z,defs,-ltic from the call to
      dh_auto_configure, so that configure will pick up the LDFLAGS from
      dpkg-buildflags(1).
    + Replace it with:
      - LIBS="-ltic" as an argument to dh_auto_configure
      - DEB_LDFLAGS_MAINT_APPEND for the rest.
        Build-Depends: dpkg-dev (>= 1.16.1).
  * Update package to Standards-Version: 3.9.3.
  * Thanks to Jakub Wilk for his thorough review.

 -- Samuel Bronson <naesten@gmail.com>  Fri, 24 Feb 2012 16:22:24 -0500