[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#660162: RFS: tack/1.07-2



On Sat, Feb 18, 2012 at 5:17 PM, Jakub Wilk <jwilk@debian.org> wrote:
> To be pedantically correct, build-dependency on autotools-dev should be
> bumped to >= 20110508.1, as this version introduced the dh addon. (I said
> “pedantically”, because a sufficient version is already in stable.)

True ...

> Could you regenerate autotools stuff at build time? autoconf-dickey is now
> in the archive, so this should be feasible. (If you feel adventurous, you
> could try also with GNU autoconf.)

... but of course, doing this pulls in dh-autoreconf, which lets me
drop the autotools-dev dependency entirely, since the "autoreconf"
addon is documented to  subsume the "autotools" addon.

> As far[0] as I can see, your debian/rules doesn't honour
> DEB_BUILD_OPTIONS=noopt. You might want to acquire “correct” {C,CPP,LD}FLAGS
> from dpkg-buildflags (enabling hardening as a side-effect).

This is true. This turned out to be mostly a matter of bumping the
debhelper compatibility level to "9". It looks like these all even
make it through the configure script...

> [0] Not very far, I didn't try to build the package yet. :P
>
> --
> Jakub Wilk

Thanks for being so patient with me!

Fixed these in <http://mentors.debian.net/debian/pool/main/t/tack/tack_1.07-1~mentors2.dsc>,
with changelog:

tack (1.07-1~mentors2) unstable; urgency=low

  * New upstream release.
  * Adopt package.
    Closes: #660140 (ITP for this package).
  * Switch to dpkg-source 3.0 (quilt) format.
  * Use dh-autoreconf to regenerate the configure script during build
    + Build-depends on dh-autoreconf and autoconf-dickey.
    + It also takes care of pulling up-to-date config.guess and config.sub
      scripts in from autotools-dev
    + Drop build-depends on autotools-dev.
  * Fix "hyphen-used-as-minus-sign" warning from lintian.
  * Update package to standards version 3.9.2.
  * Add a debian/watch file again.
  * Bump debhelper build-depends: to (>= 7.0.50~), since we use
    override_dh_<foo> targets.
  * Enable build warnings.
  * Add Vcs-Browser: and Vcs-Git: fields to debian/control.
  * Install a symlink CHANGES.gz -> changelog.gz in the doc directory.
  * Update debian/copyright to current (nearly-1.0) DEP5 format.
  * Add support for dpkg-buildflags(1) by bumping debhelper to
    compatibility level 9.

 -- Samuel Bronson <naesten@gmail.com>  Fri, 17 Feb 2012 14:12:03 -0500



Reply to: