[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: cityhash - family of non-cryptographic hash functions for strings



Hi Alessandro,

On Wed, 2011-06-15 at 16:24 +0200, Alessandro Ghedini wrote:
> On Wed, Jun 15, 2011 at 03:36:55PM +0200, Kilian Krause wrote:
> > Hi Alessandro,
> > 
> > On Wed, 2011-06-15 at 15:04 +0200, Alessandro Ghedini wrote:
> > > Thank you for your review. I've uploaded the new package to mentors.d.n (the
> > > changes are also available on the git repository).
> > 
> > Excellent.
> > 
> > Have you talked to upstream whether they want to fix 
> > 
> > dpkg-shlibdeps: warning: dependency on libstdc++.so.6 could be avoided
> > if "debian/libcityhash0/usr/lib/libcityhash.so.0.0.0" were not uselessly
> > linked against it (they use none of its symbols).
> > dpkg-shlibdeps: warning: dependency on libgcc_s.so.1 could be avoided if
> > "debian/libcityhash0/usr/lib/libcityhash.so.0.0.0" were not uselessly
> > linked against it (they use none of its symbols).
> > 
> > in the next release?
> 
> Nope. AFAIK g++ automatically links against libstdc++ and libgcc_s. The 
> only way I know to avoid this would be to pass -Wl,--as-needed to the 
> compiler using LDFLAGS, but it doesn't work when using libtool, as explained
> in #347650.
> 
> There's a patch for ltmain.sh floating around, but I do not think it is 
> worth the maintainance overhead in this case, given that both libstdc++6
> and libgcc1 are "Priority: required" packages.

ok. Thanks for the explanation. 

cityhash 1.0.2-1 was just uploaded.

-- 
Cheers,
Kilian

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: